Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60489

Modals in calendar don't load and display content smoothly

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Please test on both Clean and Boost themes

      Calendar test (master only)

      1. Log in as any user
      2. Go to the calendar
      3. Create a new event by either clicking the “new event” button or clicking on one of the days in the calendar
      4. CONFIRM that the modal open and shows a loading icon and the height change of the modal is animated and the form fades in (it’s very quick)
      5. Fill out the form and save the new event
      6. Click on the event in the calendar
      7. CONFIRM that the modal shows a loading icon and the height change is animated

      General test (master, 33, and 32)

      1. Add the test files to your local moodle instance
        • Either:
          • Cherry pick the commit from git@github.com:ryanwyllie/moodle.git MDL-60489-master-test 19fc550406be0a5769f08aa2f00ba70099097fe6
          • Download the attached files from this issue and place them in lib/templates/test_modal.mustache and in the root directory modal_test.php
      2. Navigate to <your_moodle>/modal_test.php
      3. Read through each of the test scenarios and click the “open” button on each to see the modal work
      4. CONFIRM that the modal appears as described in each test scenario
      Show
      Please test on both Clean and Boost themes Calendar test (master only) Log in as any user Go to the calendar Create a new event by either clicking the “new event” button or clicking on one of the days in the calendar CONFIRM that the modal open and shows a loading icon and the height change of the modal is animated and the form fades in (it’s very quick) Fill out the form and save the new event Click on the event in the calendar CONFIRM that the modal shows a loading icon and the height change is animated General test (master, 33, and 32) Add the test files to your local moodle instance Either: Cherry pick the commit from git@github.com:ryanwyllie/moodle.git MDL-60489 -master-test 19fc550406be0a5769f08aa2f00ba70099097fe6 Download the attached files from this issue and place them in lib/templates/test_modal.mustache and in the root directory modal_test.php Navigate to <your_moodle>/modal_test.php Read through each of the test scenarios and click the “open” button on each to see the modal work CONFIRM that the modal appears as described in each test scenario
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-60489-master

      Description

      The modal UI bounces around very quickly between different heights when it is opened in the calendar. It is a bad experience for the user and doesn't look very polished.

      The modal should gracefully scale to the correct height and render the content smoothly.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ryanwyllie Ryan Wyllie
                Reporter:
                ryanwyllie Ryan Wyllie
                Peer reviewer:
                Simey Lameze
                Integrator:
                Andrew Nicols
                Tester:
                Adrian Greeve
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17