Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60503

Pin node version on all branches (to v8.9[.x])

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60503-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Run grunt with any version of node other than 8.9

      Verify grunt refuses to run

       

      Verifying that grunt does run with the correct version of node can be done by checking the travis build.

      Show
      Run grunt with any version of node other than 8.9 Verify grunt refuses to run   Verifying that grunt does run with the correct version of node can be done by checking the travis build.

      Description

      We need the build artifacts to be generated the same for all Moodle developers so we need to specify the node version used to generate the npm-shrinkwrap file. 

      Node has an LTS scheduled for October 31 - as soon as it is released we should lock to that version on all branches. 

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60456 Latest node + npm versions change the format of npm-shrinkwrap.json

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-61893 Time to bump Node.js "Carbon" version again

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-5148 raise prechecker nodejs/npm to stable when possible

          • Low - Cosmetic problems, nice-to-have features
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Andrew Lyons Andrew Lyons
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17