Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60526

"Boost" adds the attribute `type` to the radio `input` tag twice.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.3.4, 3.4.1
    • 3.4
    • Themes
    • Any
    • MOODLE_34_STABLE
    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • MDL-60526-master
    • Hide

      Go to Calendar. Click on the Export calendar button at the bottom of the page.

      View page source in your browser (do not use the inspector it will tell you lies!). 

      Search for the string: type="radio"

      Verify in each input tag, the type="radio" attribute is repeated only once.

       

      This change should also be tested with behat. 

      Show
      Go to Calendar. Click on the Export calendar button at the bottom of the page. View page source in your browser (do not use the inspector it will tell you lies!).  Search for the string: type="radio" Verify in each input tag, the type="radio" attribute is repeated only once.   This change should also be tested with behat. 

    Description

      Go to master/calendar/export.php?theme=clean
      ask for the html source
      and look for `Events related to courses`.
      You will find:

      {{<span>
          <input name="events[exportevents]" value="courses" type="radio" id="id_events_exportevents_courses" />
          <label for="id_events_exportevents_courses">Events related to courses</label>
      </span>}}
      All is correct.

      Now perform the same check using boost.

      Go to master/calendar/export.php?theme=boost
      ask for the html source
      and look for `Events related to courses`.
      You will find:
      {{<label class="form-check-inline form-check-label  fitem  ">
          <input type="radio" name="events[exportevents]" id="id_events_exportevents_courses" value="courses" type="radio" >
          Events related to courses
      </label>}}

      As you can see, you can find the attribute `type` of the radio `input` tag twice.

      Attachments

        Activity

          People

            damyon Damyon Wiese
            daniss Daniele Cordella
            Luca Bösch Luca Bösch
            David Monllaó David Monllaó
            Rayna Mae Jayco Rayna Mae Jayco
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.