[MDL-60539] httpsreplace tools sets SQL debugging - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-60539~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/50e48a8f2d...MDL-60539-master
Testing Instructions:
Hide

Choose a lucky course

Edit settings

Set the following as it's summary:

<img src="http://intentionally.unavailable/test.png"> <img src="http://download.moodle.org/unittest/test.jpg">

Navigate to site admin -> Security -> HTTPS conversion tool

Run the tool, tick the box, and go

Confirm that you don't see SQL debugging as in attached screenshot
Show
Choose a lucky course Edit settings Set the following as it's summary: <img src="http://intentionally.unavailable/test.png"> <img src="http://download.moodle.org/unittest/test.jpg"> Navigate to site admin -> Security -> HTTPS conversion tool Run the tool, tick the box, and go Confirm that you don't see SQL debugging as in attached screenshot

admin/tool/httpsreplace/classes/url_finder.php

        $DB->set_debug(true);

        $DB->replace_all_text($table, $column, $search, $replace);

        $DB->set_debug(false);

This causes the SQL to be output at time of conversion.

is a regression caused by

MDL-46269 Convert http embedded content to https on https sites where available

Participants:: Andrew Lyons, Ankit Agarwal, CiBoT, David Scotson, Eloy Lafuente (stronk7), Jake Dallimore, Jun Pataleta, Marina Glancy, Matt Porritt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo