Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60539

httpsreplace tools sets SQL debugging

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4, 3.5
    • Fix Version/s: None
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Choose a lucky course
      2. Edit settings
      3. Set the following as it's summary:

        <img src="http://intentionally.unavailable/test.png"> <img src="http://download.moodle.org/unittest/test.jpg">
        

      4. Navigate to site admin -> Security -> HTTPS conversion tool
      5. Run the tool, tick the box, and go
        1. Confirm that you don't see SQL debugging as in attached screenshot
      Show
      Choose a lucky course Edit settings Set the following as it's summary: <img src="http://intentionally.unavailable/test.png"> <img src="http://download.moodle.org/unittest/test.jpg"> Navigate to site admin -> Security -> HTTPS conversion tool Run the tool, tick the box, and go Confirm that you don't see SQL debugging as in attached screenshot
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull Master Branch:
      MDL-60539-master

      Description

      admin/tool/httpsreplace/classes/url_finder.php

              $DB->set_debug(true);
              $DB->replace_all_text($table, $column, $search, $replace);
              $DB->set_debug(false);
      

      This causes the SQL to be output at time of conversion.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Jake Dallimore Jake Dallimore
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated: