Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60542

RSS: It does not turn off auto-discovery of feeds

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.3.2
    • Fix Version/s: None
    • Component/s: RSS
    • Labels:
    • Affected Branches:
      MOODLE_33_STABLE

      Description

      How to see the bug:

      1. Create a new RSS feed;
      2. Open the created RSS feed for editing;
      3. Turn off the Enable auto-discovery of feeds and save the result.
      4. Re-open the RSS feed for editing, the result was not saved.

      Why is this happening?

      The $mform->get_data() function does not return null or empty values.

      How it is possible to correct a bug?

      Add additional checks in the file editfeed.php:

      --- a/blocks/rss_client/editfeed.php
      +++ b/blocks/rss_client/editfeed.php
      @@ -49,7 +49,7 @@ class feed_edit_form extends moodleform {
               $mform->setType('url', PARAM_URL);
               $mform->addRule('url', null, 'required');
       
      -        $mform->addElement('checkbox', 'autodiscovery', get_string('enableautodiscovery', 'block_rss_client'));
      +        $mform->addElement('advcheckbox', 'autodiscovery', get_string('enableautodiscovery', 'block_rss_client'));
               $mform->setDefault('autodiscovery', 1);
               $mform->setAdvanced('autodiscovery');
               $mform->addHelpButton('autodiscovery', 'enableautodiscovery', 'block_rss_client');
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              valentineus valentineus
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: