Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60547

Notifications popover: Mark all as read let the page jump to the top

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.5, 3.3, 3.4
    • Fix Version/s: 3.3.5, 3.4.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as a user
      2. Scroll down the page a little bit
      3. Click on the "notifications" icon in the navbar
      4. In the popover header click on the "Mark all as read" icon
      5. Make sure that the page in the background does not jump to the top
      Show
      Login as a user Scroll down the page a little bit Click on the "notifications" icon in the navbar In the popover header click on the "Mark all as read" icon Make sure that the page in the background does not jump to the top
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60547-master

      Description

      Hi,

      when clicking on the "Mark all as read" icon within the notifications popover the page in the background jumps to the top.
      This is not the case with the "Mark all as read" icon in the messages popover...

      Steps to reproduce

      1. Login as a user
      2. Scroll down the page a little bit
      3. Click on the "notifications" icon in the navbar
      4. In the popover header click on the "Mark all as read" icon
      5. => See that the page in the background jumps to the top
      6. Try the same steps with the messages
      7. => See that the page in the background stays at it's position the user scrolled to

      Thoughts
      I've had a look at the code and compared the HTML structure and also the Code behind it.
      The methods notification_popover_controller.js and message_popover_controller.js differ in the method "markAllAsRead"

      I've tried to complete the method from the notification_popover_conroller.js with the code from the message_popover_controller.js but it did not solve this problem.
      So I really don't know why both buttons behave differently.... But it would be great if both buttons would behave equally.

      Best, Kathrin

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                19/Mar/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 18 minutes
                18m