Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60564

The day_exporter class unnecessarily defines and calls get_course_filter_selector()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course.
      2. Enrol the admin as a student in the course.
      3. Go to the course calendar and add a few events (some course, some user, some whatever).
      4. Go to the home page and add the calendar block if it isn't there.
      5. Check the block displays correctly and the events are listed.
      6. Navigate between months
      7. Check that the months update both here and in the three-month view
      8. View a specific day by clicking the date on a day with an event
      9. Check that the events are listed properly
      10. Use the nav links to change days
      11. Check that the events are listed properly
      Show
      Create a course. Enrol the admin as a student in the course. Go to the course calendar and add a few events (some course, some user, some whatever). Go to the home page and add the calendar block if it isn't there. Check the block displays correctly and the events are listed. Navigate between months Check that the months update both here and in the three-month view View a specific day by clicking the date on a day with an event Check that the events are listed properly Use the nav links to change days Check that the events are listed properly
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60564_master

      Description

      The function get_course_filter_selector() in day_exporter.php copies the exact logic in the function course_filter_selector() in calendar/renderer.php. The other exporters use the renderer appropriately.

      There is also the random comment // TODO remove this code on MDL-60096 in the code, but MDL-60096 is closed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                markn Mark Nelson
                Reporter:
                markn Mark Nelson
                Peer reviewer:
                Andrew Nicols
                Integrator:
                Damyon Wiese
                Tester:
                Simey Lameze
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17