Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60572

Field type for forgottenpasswordurl in tool_mobile_get_public_config WS is incorrect

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60572-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      Before the patch
      1. Login as admin.
      2. Navigate to Site administration / Plugins / Authentication / Manage authentication
      3. Set the "Forgotten password URL" setttig to a non-http/https URL. For example:

        mailto:someone@example.com

      4. Save the changes
      After the patch
      Master only
      1. Purge caches
      2. Navigate to admin/index.php.
        • Confirm that you see a warning indicating that the forgotten password URL is invalid.
      3. Click on the Check button
        • Confirm that you are redirected to the "Manage authentication" admin page.
      4. With the "Forgotten password URL" setttig still set to an invalid URL, click "Save changes".
        • Confirm that you get a validation error indicating that the forgotten password URL is invalid.
      5. Now, enter a valid http/https URL for the forgotten password URL. (Or just set it to empty)
      6. Click "Save changes"
        • Confirm that the changes are successfully saved.
      7. Navigate to admin/index.php.
        • Confirm that you don't see the warning about the invalid forgotten password URL.
      Master, 33 and 32
      1. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      2. Navigate to Site administration / Plugins / Authentication / Manage authentication
      3. Set the "Forgotten password URL" setttig to a non-http/https URL. For example:

        mailto:someone@example.com


        Note: On master, you'll have to manually update the mdl_config table in the database directly to go over the form validation: 

        UPDATE mdl_config SET value = 'mailto:someone@example.com' WHERE name = 'forgottenpasswordurl'

      4. Try to access to the site using the mobile app
        • Confirm that you can still log-in even if the "forgottenpasswordurl" setting is not correct
      Show
      Before the patch Login as admin. Navigate to Site administration / Plugins / Authentication / Manage authentication Set the " Forgotten password URL " setttig to a non-http/https URL. For example: mailto:someone@example.com Save the changes After the patch Master only Purge caches Navigate to admin/index.php . Confirm that you see a warning indicating that the forgotten password URL is invalid. Click on the Check button Confirm that you are redirected to the " Manage authentication " admin page. With the " Forgotten password URL " setttig still set to an invalid URL, click " Save changes ". Confirm that you get a validation error indicating that the forgotten password URL is invalid. Now, enter a valid http/https URL for the forgotten password URL. (Or just set it to empty) Click " Save changes " Confirm that the changes are successfully saved. Navigate to admin/index.php . Confirm that you don't see the warning about the invalid forgotten password URL. Master, 33 and 32 As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Navigate to Site administration / Plugins / Authentication / Manage authentication Set the " Forgotten password URL " setttig to a non-http/https URL. For example: mailto:someone@example.com Note: On master, you'll have to manually update the mdl_config table in the database directly to go over the form validation: UPDATE mdl_config SET value = 'mailto:someone@example.com' WHERE name = 'forgottenpasswordurl' Try to access to the site using the mobile app Confirm that you can still log-in even if the " forgottenpasswordurl " setting is not correct

      Description

      This is similar to what happened in MDL-60141, in this case some people use a mailto instead an URL, example:

      "debuginfo":"forgottenpasswordurl => Invalid response value detected: Invalid external api response: the value is \"mailto:xx@abc.de\", the server was expecting \"url\" type\nError code: invalidresponse"

        Attachments

          Activity

            People

            Assignee:
            jleyva Juan Leyva
            Reporter:
            jleyva Juan Leyva
            Peer reviewer:
            Dani Palou Dani Palou
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17