Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60591

Forum inbound processor discards the inline images if message contains quoted text

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.2, 3.4, 3.5
    • Fix Version/s: 3.3.4, 3.4.1
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up inboud email as described in MDLQA-11479
      2. when replying to a forum post by email do not remove the original text and add inline images (drag and drop them in gmail, for example)
      3. run cron (again, see QA test)
      4. edit the post and make sure the images are attached as attachments in the bottom of the text and only [Image imagename] is left in the text. If you edit the post you will see the images in the attachments area
      5. reply to post again by email but this time delete original text, add inline images
      6. view the post and make sure the images are displayed inside the text like they were in the email. If you edit the post you will see that attachments area is empty
      7. reply to post again but this time attach images or other files using attachment button
      8. make sure they are displayed in the post as attachments
      Show
      Set up inboud email as described in MDLQA-11479 when replying to a forum post by email do not remove the original text and add inline images (drag and drop them in gmail, for example) run cron (again, see QA test) edit the post and make sure the images are attached as attachments in the bottom of the text and only [Image imagename] is left in the text. If you edit the post you will see the images in the attachments area reply to post again by email but this time delete original text, add inline images view the post and make sure the images are displayed inside the text like they were in the email. If you edit the post you will see that attachments area is empty reply to post again but this time attach images or other files using attachment button make sure they are displayed in the post as attachments
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      wip-MDL-60591-master

      Description

      1. Set up inboud email as described in MDLQA-11479
      2. when replying to a forum post by email do not remove the original text and add inline images (drag and drop them in gmail, for example)
      3. you will not see the image in the forum post but see something like [image: Inline image 1]

      This happens because mod_forum\message\inbound\reply_handler::remove_quoted_text() converts messages to plain text if they contain quoted text

      However process_message() adds inline images to the body text instead of to the attachment area

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18