Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60611

PHP7.2 supported on Moodle 3.4 - include in travis. Bump phpunit to 6.4

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.4
    • 3.4
    • General
    • MOODLE_34_STABLE
    • MOODLE_34_STABLE
    • Hide
      1. Verify unit tests run perfectly agains php 70, 71 an 72.
      2. Verify travis passes with the patch applied.
      3. *Developer required* : Perform some exploratory testing verifying different options. Everything should work normally. Like...
        1. running only one test
        2. using -c (requires --buildcomponentconfigs in util.php)
        3. using some --stop-on-xxx option and forcing it to happen.
        4. running some --coverage option (may require installing xdebug...)
        5. using the --filter option
        6. ...
      4. *No action needed*: Integrators will verify that all the master chains are working ok with phpunit6.
      5. *No action needed*: Once the change has been rolled upstream (created issues for them), these followups will complete verifications.:
        1. verify that uses of moodle-plugin-ci plugins are working ok, specifically phpunit, master and php72 combinations (they were producing some PHP Notices originally). (MDL-60706)
        2. add some jobs in CI servers to get 7.2 covered (MDLSITE-5270)
      Show
      Verify unit tests run perfectly agains php 70, 71 an 72. Verify travis passes with the patch applied. * Developer required * : Perform some exploratory testing verifying different options. Everything should work normally. Like... running only one test using -c (requires --buildcomponentconfigs in util.php) using some --stop-on-xxx option and forcing it to happen. running some --coverage option (may require installing xdebug...) using the --filter option ... * No action needed *: Integrators will verify that all the master chains are working ok with phpunit6. * No action needed *: Once the change has been rolled upstream (created issues for them), these followups will complete verifications.: verify that uses of moodle-plugin-ci plugins are working ok, specifically phpunit, master and php72 combinations (they were producing some PHP Notices originally). ( MDL-60706 ) add some jobs in CI servers to get 7.2 covered ( MDLSITE-5270 )

    Description

      As suggested by matteo (thanks!)

      should .travis.yml be improved too, for running PHP 7.2 on the master branch only, e.g. via a matrix.include entry?

      Attachments

        Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-5270 Cover php72 in the CI servers

          • Low - Cosmetic problems, nice-to-have features
          • Open

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-60706 Verify moodle-plugin-ci are working ok with phpunit6 (and php72)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60672 Review phpunit risky tests

          • Minor - Minor loss of function where workaround is possible
          • Reopened

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-60745 Mini bump composer.lock to phpunit 6.4.4

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              marina Marina Glancy
              Marina Glancy Marina Glancy
              Jun Pataleta Jun Pataleta
              Damyon Wiese Damyon Wiese
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Nov/17