Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60611

PHP7.2 supported on Moodle 3.4 - include in travis. Bump phpunit to 6.4

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide
      1. Verify unit tests run perfectly agains php 70, 71 an 72.
      2. Verify travis passes with the patch applied.
      3. *Developer required* : Perform some exploratory testing verifying different options. Everything should work normally. Like...
        1. running only one test
        2. using -c (requires --buildcomponentconfigs in util.php)
        3. using some --stop-on-xxx option and forcing it to happen.
        4. running some --coverage option (may require installing xdebug...)
        5. using the --filter option
        6. ...
      4. *No action needed*: Integrators will verify that all the master chains are working ok with phpunit6.
      5. *No action needed*: Once the change has been rolled upstream (created issues for them), these followups will complete verifications.:
        1. verify that uses of moodle-plugin-ci plugins are working ok, specifically phpunit, master and php72 combinations (they were producing some PHP Notices originally). (MDL-60706)
        2. add some jobs in CI servers to get 7.2 covered (MDLSITE-5270)
      Show
      Verify unit tests run perfectly agains php 70, 71 an 72. Verify travis passes with the patch applied. * Developer required * : Perform some exploratory testing verifying different options. Everything should work normally. Like... running only one test using -c (requires --buildcomponentconfigs in util.php) using some --stop-on-xxx option and forcing it to happen. running some --coverage option (may require installing xdebug...) using the --filter option ... * No action needed *: Integrators will verify that all the master chains are working ok with phpunit6. * No action needed *: Once the change has been rolled upstream (created issues for them), these followups will complete verifications.: verify that uses of moodle-plugin-ci plugins are working ok, specifically phpunit, master and php72 combinations (they were producing some PHP Notices originally). ( MDL-60706 ) add some jobs in CI servers to get 7.2 covered ( MDLSITE-5270 )
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      As suggested by Matteo Scaramuccia (thanks!)

      should .travis.yml be improved too, for running PHP 7.2 on the master branch only, e.g. via a matrix.include entry?

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17