Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60634

Mobile App config times out when custom login in use on site

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. This should be testing in a site using http and a site using https (can be the same site), first we'll test with the site using http
      2. Disable "Mobile services": Site administration ► Mobile app ► Mobile settings (if they were enabled)
      3. Enabled them back and check that you see the following message: " It is recommended to enable HTTPS with a valid certificate. The Moodle app will always try to use a secured connection first. " (Please note that in master you will see it with a yellow background and in stables with a red one)
      4. Now, configure your local site to use https (you can use ngrok)
      5. Disable "Mobile services": Site administration ► Mobile app ► Mobile settings (if they were enabled)
      6. Enabled them back and check that you see don't see the messages indicated in step 3 anymore
      Show
      This should be testing in a site using http and a site using https (can be the same site), first we'll test with the site using http Disable "Mobile services": Site administration ► Mobile app ► Mobile settings (if they were enabled) Enabled them back and check that you see the following message: " It is recommended to enable HTTPS with a valid certificate. The Moodle app will always try to use a secured connection first. " (Please note that in master you will see it with a yellow background and in stables with a red one) Now, configure your local site to use https (you can use ngrok) Disable "Mobile services": Site administration ► Mobile app ► Mobile settings (if they were enabled) Enabled them back and check that you see don't see the messages indicated in step 3 anymore
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60634-master

      Description

      the page: admin/settings.php?section=mobile times out when saml2 plugin is installed and configured - but I think there are other cases where this will also fail incorrectly - such as when a custom login url is set.

      in admin_setting_enablemobileservice a check is made to see if https is supported but this points at the login/index.php page which may not actually be in use and may redirect automatically to something else (saml etc) - we've seen this reported here:
      https://github.com/catalyst/moodle-auth_saml2/issues/146

      I see 3.4 changes this check a bit and it now checks cert validity as well but it's hard to see if the same issue occurs.

      in the stable branches wouldn't be be better to check if $CFG->wwwroot has "https://" and if so - don't bother with the curl call?

      Also - considering loginhttps has been deprecated and manual login form isn't required to be used for mobile app support I'm not sure that the login page should be used for checking https support?

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17