Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60657

Modal titles missing padding

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      NOTE: All the scenarios has to be tested using both Boost and Clean themes.

      Upgrade notice check

      1. Edit your version.php file and increase the $version number
      2. Log in as admin
      3. CONFIRM that the "Confirm" text in the header of the in page modal is padded in from the left hand side of the modal border (there should be equal whitespace on the text's left, top, and bottom sides).

      File picker check

      1. Log in as admin
      2. Create a course and enrol at least one teacher and at least one student
      3. Log in as the teacher
      4. Create an assignment activity
      5. Click the "manage files" button in the atto editor for the description
      6. CONFIRM that the modal title text is padded as described above
      7. Finish creating the activity

      Summary modal check

      1. Still logged in as the teacher
      2. Navigate to the calendar
      3. Click on the assignment due date event
      4. CONFIRM that the padding on the modal title looks as described above

      Grade panel popup

      1. Still logged in as the teacher
      2. Navigate to the assignment activity
      3. Click "grade"
      4. CONFIRM that the header in the "feedback comments" panel on the right side of the grading page appears as it did in 33. It should look like
      Show
      NOTE: All the scenarios has to be tested using both Boost and Clean themes. Upgrade notice check Edit your version.php file and increase the $version number Log in as admin CONFIRM that the "Confirm" text in the header of the in page modal is padded in from the left hand side of the modal border (there should be equal whitespace on the text's left, top, and bottom sides). File picker check Log in as admin Create a course and enrol at least one teacher and at least one student Log in as the teacher Create an assignment activity Click the "manage files" button in the atto editor for the description CONFIRM that the modal title text is padded as described above Finish creating the activity Summary modal check Still logged in as the teacher Navigate to the calendar Click on the assignment due date event CONFIRM that the padding on the modal title looks as described above Grade panel popup Still logged in as the teacher Navigate to the assignment activity Click "grade" CONFIRM that the header in the "feedback comments" panel on the right side of the grading page appears as it did in 33. It should look like
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60657-master

      Description

      This is a regression from MDL-59936 which causes all modal dialog titles to be displayed without padding on the left and right.

        Attachments

        1. Chrome.png
          Chrome.png
          23 kB
        2. feedback_comments_header.png
          feedback_comments_header.png
          26 kB
        3. ie11.PNG
          ie11.PNG
          20 kB
        4. IE11.png
          IE11.png
          23 kB
        5. photo_2017-11-02_10-34-40.jpg
          photo_2017-11-02_10-34-40.jpg
          23 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17