Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60672

Review phpunit risky tests

    XMLWordPrintable

Details

    • Bug
    • Status: Reopened
    • Minor
    • Resolution: Unresolved
    • 3.4
    • None
    • Unit tests
    • MOODLE_34_STABLE

    Description

      Working on MDL-60611, to get phpunit 6 support to Moodle 3.4 and up... one of the things detected is that we have a good number of "risky" (without assertions") tests in codebase.

      We have them not being reported using beStrictAboutTestsThatDoNotTestAnything="false" in phpunit.xml, but ideally we should not have tests of this type.

      1) if they are empty should be deleted.
      2) if they are not tests, but support stuff, should be renamed or moved.

      So, this is about:

      a) detect all the risky tests we have
      b) try to kill them, so we can go to the default "beStrict=true"

      Ciao

      Attachments

        Issue Links

          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-60611 PHP7.2 supported on Moodle 3.4 - include in travis. Bump phpunit to 6.4

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-70070 Some data providers incorrectly named

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-76662 Logstore get_supported_reports test methods do not assert anything

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              stronk7 Eloy Lafuente (stronk7)
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: