Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60672

Review phpunit risky tests

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4
    • Fix Version/s: None
    • Component/s: Unit tests
    • Labels:
    • Affected Branches:
      MOODLE_34_STABLE

      Description

      Working on MDL-60611, to get phpunit 6 support to Moodle 3.4 and up... one of the things detected is that we have a good number of "risky" (without assertions") tests in codebase.

      We have them not being reported using beStrictAboutTestsThatDoNotTestAnything="false" in phpunit.xml, but ideally we should not have tests of this type.

      1) if they are empty should be deleted.
      2) if they are not tests, but support stuff, should be renamed or moved.

      So, this is about:

      a) detect all the risky tests we have
      b) try to kill them, so we can go to the default "beStrict=true"

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                2 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: