Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60680

Improve push notifications

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This is not easy to test because it depends on an external system (Airnotifier) that is not yet updated to use the new customdata information coming from Moodle.
      So basically, I tried to cover everything with unit tests and the following test is just to check that no regression was added in Moodle messaging system:

      1. As admin: Enable mailcatcher, mailhog, or have e-mail configured
      2. Create a course, enrol two users as studnets (S1 and S2) and one user as teacher (T1) with valid email addresses for at least S1 and S2 if you are not using mailcatcher or mailhog
      3. Create a forum in the course with the "Subscription mode" force to all users
      4. In the forum settings the maxeditingtime to something really low (1 minute)
      5. Access to the site with U1 and post in the forum
      6. Wait for a minute and run the cron:

        php admin/tool/task/cli/schedule_task.php --execute="\mod_forum\task\cron_task" 
        

      7. Open mailhog/mailcatcher/etc and find the e-mails
      8. Confirm that all the emails received from the site contain the new post information (subject, body, author, etc..
      Show
      This is not easy to test because it depends on an external system (Airnotifier) that is not yet updated to use the new customdata information coming from Moodle. So basically, I tried to cover everything with unit tests and the following test is just to check that no regression was added in Moodle messaging system: As admin: Enable mailcatcher, mailhog, or have e-mail configured Create a course, enrol two users as studnets (S1 and S2) and one user as teacher (T1) with valid email addresses for at least S1 and S2 if you are not using mailcatcher or mailhog Create a forum in the course with the "Subscription mode" force to all users In the forum settings the maxeditingtime to something really low (1 minute) Access to the site with U1 and post in the forum Wait for a minute and run the cron: php admin/tool/task/cli/schedule_task.php --execute="\mod_forum\task\cron_task" Open mailhog/mailcatcher/etc and find the e-mails Confirm that all the emails received from the site contain the new post information (subject, body, author, etc..
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60680-master

      Description

      In this issue we plan to improve Push notifications, we'll be working on this four areas:
      1 Enable more "message providers" for the Mobile app in new installations or during upgrade. So students will receive Push notifications even if the site admin didn't configure them yet.
      2 Review all the data included in a "message/notification" so we can receive all the necessary context information in the app to open the "page related" to the notification in the app once the user clicks on the notification text (this is working partially now).
      3 Improve the media information included in a "message/notificaiton" so we can display "Rich" Push Notifications, including icons, large images, badge icons, etc..
      4 Support "In-line action buttons", so you can, for example, accept a "Contact request" via the notification itself (with an "Accept" or "Decline" button just bellow the information of the notification.

      Please, note that iOS Push notifications are quite limited compared to Android ones, and that the Cordova framework and hybrid apps have additional limitations.

      Push and Web notifications usually come with:

      • Badge icon: The badge is a small monochrome icon that is used to portray a little more information to the user about where the notification is from.
      • Custom icons: The icon option is essentially a small image you can show next to the title and body text.
      • Custom pictures (large images): The image option can be used to display a larger image to the user. This is particularly useful to display a preview image to the user. 2x1 ratio recommended

      We should support these in our message base class and in the "messages" and "notifications" tables. (notificationbadgeurl, notificationiconurl, notificationimageurl)

      See more information an screenshot examples here:

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 10 minutes
                  1h 10m