[MDL-60683] Quiz uses legacy cron - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.3, 3.7
Fix Version/s: 3.7
Component/s: Quiz
Labels:
- ci
- triaged

Testing Instructions:

Hide

Check scheduled tasks execute on schedule (every minute)

Run cron repeatedly. The following command will cause it to be run 5 times with a 30 second gap between each:
for x in `seq 1 5`; do php admin/cli/cron.php; sleep 30; done
Login as admin
Navigate to Site administration > Server > Tasks > Task logs
Filter by "Quiz"
1. Confirm that you see regular attempts to execute each of the following:
  1. "Updating overdue quiz attempts"
  2. "Legacy Cron Quiz Reports"
  3. "Legacy Cron Quiz Access Rules"

Check scheduled tasks run correct when manually run.

Open a console and run each of the following commands individually

Confirm that all run without issue and do not fail

php admin/tool/task/cli/scheduled_task.php --execute="\mod_quiz\task\update_overdue_attempts"

php admin/tool/task/cli/scheduled_task.php --execute="\mod_quiz\task\legacy_quiz_reports_cron"

php admin/tool/task/cli/scheduled_task.php --execute="\mod_quiz\task\legacy_quiz_accessrules_cron"

Show

Check scheduled tasks execute on schedule (every minute) Run cron repeatedly. The following command will cause it to be run 5 times with a 30 second gap between each: for x in `seq 1 5`; do php admin/cli/cron.php; sleep 30; done Login as admin Navigate to Site administration > Server > Tasks > Task logs Filter by " Quiz " Confirm that you see regular attempts to execute each of the following: " Updating overdue quiz attempts " " Legacy Cron Quiz Reports " " Legacy Cron Quiz Access Rules " Check scheduled tasks run correct when manually run. Open a console and run each of the following commands individually Confirm that all run without issue and do not fail php admin/tool/task/cli/scheduled_task.php --execute="\mod_quiz\task\update_overdue_attempts" php admin/tool/task/cli/scheduled_task.php --execute="\mod_quiz\task\legacy_quiz_reports_cron" php admin/tool/task/cli/scheduled_task.php --execute="\mod_quiz\task\legacy_quiz_accessrules_cron"

Affected Branches:
MOODLE_33_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Epic Link:
Remove any legacy cron from Moodle standard distribution
Pull from Repository:
https://github.com/mhughes2k/moodle
Pull Master Branch:
~~MDL-60683~~_cron_to_task
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...mhughes2k:MDL-60683_cron_to_task

Description

quiz module is still using legacy cron task to close open events. This probably should be moved over to the Scheduled Tasks system

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

image-2019-02-27-08-39-19-692.png
236 kB
27/Feb/19 8:39 AM

Issue Links

Discovered while testing

MDL-60802 cron_execute_plugin_type should report that plugins are using "old" cron implemenation

Closed

Activity

People

Assignee:: Michael Hughes

Reporter:: Michael Hughes

Peer reviewer:: Tim Hunt

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, Ankit Agarwal, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Janelle Barcega, Marina Glancy, Michael Hughes, Simey Lameze, Tim Hunt

Component watchers:: Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 04/Nov/17 8:48 AM

Updated:: 01/Mar/19 2:58 AM

Resolved:: 01/Mar/19 2:58 AM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Remaining:

Logged:

1h 20m