Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60685

Assignment feedback lists site administrator as the grader after overrides are saved by a teacher

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.2, 3.4.3, 3.5.2, 3.6
    • Fix Version/s: 3.4.6, 3.5.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Make sure unoconv document processor is enabled and working.

      Create a course with a teacher and a student in it.

      Create an assignment that allows file submissions.

      Login as the student and upload an image (png) file to the assignment.

      Login as the teacher and go to the gradebook (not the assignment) and override the grade for the student in the assignment.

      From the command line execute the convert submissions scheduled task

      sudo -u www-data /usr/bin/php admin/tool/task/cli/schedule_task.php --execute="\assignfeedback_editpdf\task\convert_submissions"

       

      Login as the student and view the assignment. They should see the grade entered by the teacher and the teacher should be listed in the "Graded by" table cell. The admin user should not be listed as the "Graded by" user.

       

      Show
      Make sure unoconv document processor is enabled and working. Create a course with a teacher and a student in it. Create an assignment that allows file submissions. Login as the student and upload an image (png) file to the assignment. Login as the teacher and go to the gradebook (not the assignment) and override the grade for the student in the assignment. From the command line execute the convert submissions scheduled task sudo -u www-data /usr/bin/php admin/tool/task/cli/schedule_task.php --execute="\assignfeedback_editpdf\task\convert_submissions"   Login as the student and view the assignment. They should see the grade entered by the teacher and the teacher should be listed in the "Graded by" table cell. The admin user should not be listed as the "Graded by" user.  
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-60685-master

      Description

      This issue impacts students who view the assignment page, specifically the Feedback table.  It occurs when a teacher enters overrides when grading.  The replication steps successfully trigger the issue on an up-to-date Moodle site.

      Replication steps:

      1. Log in as a teacher and create an assignment in a course. Enable file submissions, feedback comments, feedback files.
      2. Log in as a student and submit a file to that assignment.
      3. Log in as the teacher. Go to the Grader Report. Turn Editing On. Specify a grade on the student's assignment. Click Save Changes.
      4. Log in as the student. Go to the assignment page. Scroll down to the Feedback section.
        • Observe that a Grade and Graded On is displayed.
        • Observe that no Graded By is displayed.
      5. Wait until the next 15 minute mark and refresh the assignment page as the student. Scroll down to the Feedback section.
        • Observe that a Graded By is now displayed.
        • Observe that the main site administrator is now listed as the user who graded the submission.

      I searched the Moodle Tracker for issues and have not found a ticket documenting this issue yet. This is the closest one that I can find. It suggests that the assignment feedback module cannot reliably return the userid of the grader:

      https://tracker.moodle.org/browse/MDL-36689

      When I noticed that the Graded By did not appear until the 15 minute mark, that made me think that an automated process is triggering some code that is causing the issue. So I went to the scheduled tasks page to identify everything that runs every 15 minutes. There are only a few of them. Using process of elimination, I manually executed scheduled tasks from the command line and identified that this one seems to be responsible:

      \assignfeedback_editpdf\task\convert_submissions

      If you follow the replication steps, and execute the scheduled task manually as opposed to waiting until the next "15 minute mark", the site administrator is then immediately displayed to students in the Graded By field. This makes me think that this scheduled task is somehow involved.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/18