Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60700

Some activity events don't show event type in the summary modal

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Test on Boost and Clean themes

      Setup

      NOTE: Instead of creating all the events manually, it's recommended to use data-generation tool such as https://github.com/andrewnicols/moodle-datagenerator . It'll avoid you to create some of the events.

      1. Log in as admin
      2. Create a course
      3. Enrol a user as a teacher in the course (t1)
      4. Create a group in the course (g1)
      5. Create an assignment activity in the course (make sure it has a due date)
      6. Create a chat activity in the course and make sure it has a next chat time in the future and a "Repeat/publish session times" set to "No repeats - publish the specified time only".

      Site event

      1. Log in as admin
      2. Navigate to the calendar
      3. Click “new event” and change the type of event to “Site”
      4. Fill out the form and save the event
      5. Click the newly created event on the calendar to open the summary modal
      6. CONFIRM that the event type is "Site event"

      Category event

      1. Log in as admin
      2. Navigate to the calendar
      3. Click “new event” and change the type of event to “Category”
      4. Fill out the form and save the event
      5. Click the newly created event on the calendar to open the summary modal
      6. CONFIRM that the event type is "Category event"

      User event

      1. Log in as admin
      2. Navigate to the calendar
      3. Click “new event” and change the type of event to “User” (this is the default)
      4. Fill out the form (you can add a description if you like) and save the event
      5. Click the newly created event on the calendar to open the summary modal
      6. CONFIRM that the event type is "User event"

      Activity event

      1. Log in as t1
      2. Navigate to the calendar
      3. Click on the assignment due date event
      4. CONFIRM that the event type is "Course event"
      5. CONFIRM that there is a link to the course that the activity is in
      6. Click on the chat open event
      7. CONFIRM that the event type is "Course event" (prior to this patch this would show the placeholder for the get string helper because it couldn't find a valid string)
      8. CONFIRM that there is a link to the course that the activity is in

      Course event

      1. Log in as t1
      2. Navigate to the calendar
      3. Click “new event” and change the type of event to “Course”
      4. Fill out the form and make sure you add a description and save the event
      5. Click the newly created event on the calendar to open the summary modal
      6. CONFIRM that the event type is "Course event"
      7. CONFIRM that the description content doesn't have any margin at the bottom of it (you can inspect the element using your browser's development tools if needed). See the attached image p_bottom_margin_in_calendar_modal.png to see how it looked prior to this patch.
        • NOTE: Please confirm this is the case on both the Clean and Boost themes

      Group event

      1. Log in as t1
      2. Navigate to the calendar
      3. Click “new event” and change the type of event to “Group”
      4. Fill out the form (you can add a description if you like) and save the event
      5. Click the newly created event on the calendar to open the summary modal
      6. CONFIRM that the event type is "Group event"
      Show
      Test on Boost and Clean themes Setup NOTE: Instead of creating all the events manually, it's recommended to use data-generation tool such as https://github.com/andrewnicols/moodle-datagenerator . It'll avoid you to create some of the events. Log in as admin Create a course Enrol a user as a teacher in the course (t1) Create a group in the course (g1) Create an assignment activity in the course (make sure it has a due date) Create a chat activity in the course and make sure it has a next chat time in the future and a "Repeat/publish session times" set to "No repeats - publish the specified time only". Site event Log in as admin Navigate to the calendar Click “new event” and change the type of event to “Site” Fill out the form and save the event Click the newly created event on the calendar to open the summary modal CONFIRM that the event type is "Site event" Category event Log in as admin Navigate to the calendar Click “new event” and change the type of event to “Category” Fill out the form and save the event Click the newly created event on the calendar to open the summary modal CONFIRM that the event type is "Category event" User event Log in as admin Navigate to the calendar Click “new event” and change the type of event to “User” (this is the default) Fill out the form (you can add a description if you like) and save the event Click the newly created event on the calendar to open the summary modal CONFIRM that the event type is "User event" Activity event Log in as t1 Navigate to the calendar Click on the assignment due date event CONFIRM that the event type is "Course event" CONFIRM that there is a link to the course that the activity is in Click on the chat open event CONFIRM that the event type is "Course event" (prior to this patch this would show the placeholder for the get string helper because it couldn't find a valid string) CONFIRM that there is a link to the course that the activity is in Course event Log in as t1 Navigate to the calendar Click “new event” and change the type of event to “Course” Fill out the form and make sure you add a description and save the event Click the newly created event on the calendar to open the summary modal CONFIRM that the event type is "Course event" CONFIRM that the description content doesn't have any margin at the bottom of it (you can inspect the element using your browser's development tools if needed). See the attached image p_bottom_margin_in_calendar_modal.png to see how it looked prior to this patch. NOTE : Please confirm this is the case on both the Clean and Boost themes Group event Log in as t1 Navigate to the calendar Click “new event” and change the type of event to “Group” Fill out the form (you can add a description if you like) and save the event Click the newly created event on the calendar to open the summary modal CONFIRM that the event type is "Group event"
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60700-master

      Description

      Some activity events, such as chat or forum, don't show the event type as "Course event" in the summary modal because their event type hasn't been normalised to "course" (each activity can set the event type to a value that is meaningful to that activity).

        Attachments

        1. activity-event.png
          activity-event.png
          49 kB
        2. course_event.png
          course_event.png
          53 kB
        3. p_bottom_margin_in_calendar_modal.png
          p_bottom_margin_in_calendar_modal.png
          31 kB
        4. proposal.png
          proposal.png
          54 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17