Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60741

Purge all caches outputs a developer debug message about PAGE->url not being set

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Ensure developer debug is on
      3. Inside moodledata, add an extra file to any cache folder like cache/cachestore_file/default_application/core_config, add a file that the web server does not have permission to delete. On a linux system, it may suffice to simply chmod 644 one of the cache directories within the 'moodledata/cache/cachestore_file/default_application/core_config' dir.
      4. Go to Admin -> Development -> Purge all caches and click the button.
      5. Verify that, while there is a warning from unlink about the directory being not empty, there is no error about page_url not being set.
      Show
      Log in as admin Ensure developer debug is on Inside moodledata, add an extra file to any cache folder like cache/cachestore_file/default_application/core_config, add a file that the web server does not have permission to delete. On a linux system, it may suffice to simply chmod 644 one of the cache directories within the 'moodledata/cache/cachestore_file/default_application/core_config' dir. Go to Admin -> Development -> Purge all caches and click the button. Verify that, while there is a warning from unlink about the directory being not empty, there is no error about page_url not being set.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      To reproduce:

      1. Log in as admin
      2. Ensure developer debug is on
      3. Inside moodledata, add an extra file to any cache folder like cache/cachestore_file/default_application/core_config, add a file that the web server does not have permission to delete.
      4. Go to Admin -> Development -> Purge all caches and click the button.

      Expected behaviour:

      Warning: rmdir(C:\Temp\moodledata_head/cache/cachestore_file/default_application): Directory not empty in C:\Users\tjh238\workspace\moodle_head\lib\moodlelib.php on line 9221
       
      Warning: rmdir(C:\Temp\moodledata_head/cache/cachestore_file): Directory not empty in C:\Users\tjh238\workspace\moodle_head\lib\moodlelib.php on line 9221
       
      All caches were purged.
      (Continue)
       
      Error output, so disabling automatic redirect.
      

      Actual result: Also includes this error:

      This page did not call $PAGE->set_url(...). Using http://127.0.0.1/moodle_head/admin/purgecaches.php
       
          line 600 of \lib\pagelib.php: call to debugging()
          line 820 of \lib\pagelib.php: call to moodle_page->magic_get_url()
          line 565 of \admin\tool\usertours\classes\manager.php: call to moodle_page->__get()
          line 505 of \admin\tool\usertours\classes\helper.php: call to tool_usertours\manager::get_current_tour()
          line 75 of \admin\tool\usertours\lib.php: call to tool_usertours\helper::bootstrap()
          line 1279 of \lib\outputrenderers.php: call to tool_usertours_before_footer()
          line 1134 of \lib\outputrenderers.php: call to core_renderer->footer()
          line 1845 of \lib\setuplib.php: call to core_renderer->redirect_message()
          line 2863 of \lib\weblib.php: call to bootstrap_renderer->__call()
          line 44 of \admin\purgecaches.php: call to redirect()
      

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Jake Dallimore
            Tester:
            David Mudrák (@mudrd8mz)
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jan/18