[MDL-60751] Replace useless NULL_ALLOWED on calendar externallib.php - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4
Fix Version/s: 3.4.1
Component/s: Calendar
Labels:
- ci
- triaged

Affected Branches:
MOODLE_34_STABLE
Fixed Branches:
MOODLE_34_STABLE
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Master Branch:
~~MDL-60751~~-master
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/0164f50...MDL-60751-master
Testing Instructions:

Hide

A simple sanity check on the patch should be enough.

Show
A simple sanity check on the patch should be enough.

Description

There are some calls to external_multiple_structure where a forth param is passed (NULL_ALLOWED). However that constructor only accepts 4 parameters.

Discovered by Jun during the integration review of ~~MDL-60628~~.

Attachments

Activity

People

Assignee:: Simey Lameze

Reporter:: Simey Lameze

Peer reviewer:: Mihail Geshoski

Integrator:: David Monllaó

Tester:: Ankit Agarwal

Participants:: Ankit Agarwal, CiBoT, David Monllaó, Mihail Geshoski, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 09/Nov/17 8:21 PM

Updated:: 24/Nov/17 7:11 AM

Resolved:: 24/Nov/17 7:11 AM

Fix Release Date:: 15/Jan/18