[MDL-60752] Common Cartridge import of LTI fails on MySQL - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_34_STABLE
Fixed Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-60752~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/7a571b813a...MDL-60752-master
Testing Instructions:
Hide

Make sure ~~MDL-60615~~ is in your branch (if not, wait until it's integrated).

Login as an editing teacher

Open a course

From the Settings menu, choose "Restore"

Upload the attached Common Cartridge file (py4e_export.imscc

Proceed through the restore

Confirm no errors

Perform a second restore into a different course

Confirm no errors
Show
Make sure MDL-60615 is in your branch (if not, wait until it's integrated). Login as an editing teacher Open a course From the Settings menu, choose " Restore " Upload the attached Common Cartridge file ( py4e_export.imscc Proceed through the restore Confirm no errors Perform a second restore into a different course Confirm no errors

When restoring a Common Cartridge with LTI in it and a tool URL, we're getting a fail.

See the attached IMSCC export as an example of a failing cartridge.

line 677 of /lib/dml/moodle_database.php: dml_exception thrown

line 1603 of /lib/dml/moodle_database.php: call to moodle_database->where_clause()

line 91 of /mod/lti/backup/moodle1/lib.php: call to moodle_database->get_field()

line 299 of /backup/converter/moodle1/lib.php: call to moodle1_mod_lti_handler->process_basiclti()

line 751 of /backup/converter/moodle1/lib.php: call to moodle1_converter->process_chunk()

line 178 of /backup/util/xml/parser/processors/grouped_parser_processor.class.php: call to moodle1_parser_processor->dispatch_chunk()

line 148 of /backup/util/xml/parser/processors/simplified_parser_processor.class.php: call to grouped_parser_processor->postprocess_chunk()

line 92 of /backup/util/xml/parser/processors/progressive_parser_processor.class.php: call to simplified_parser_processor->process_chunk()

line 190 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser_processor->receive_chunk()

line 278 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser->publish()

line ? of unknownfile: call to progressive_parser->end_tag()

line 179 of /backup/util/xml/parser/progressive_parser.class.php: call to xml_parse()

line 158 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser->parse()

line 150 of /backup/converter/moodle1/lib.php: call to progressive_parser->process()

line 129 of /backup/converter/convertlib.php: call to moodle1_converter->execute()

line 209 of /backup/util/helper/convert_helper.class.php: call to base_converter->convert()

line 462 of /backup/controller/restore_controller.class.php: call to convert_helper::to_moodle2_format()

line 92 of /backup/restore.php: call to restore_controller->convert()

blocks

MDLQA-11153 CLONE - A teacher can import an IMS Common Cartridge package

Participants:: Andrew Lyons, Ankit Agarwal, CiBoT, Damyon Wiese, David Monllaó

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo