Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60767

admin settings: validation errors not reported in one setting if other settings are also changed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      As admin:

      1. Go to Admin > Security > HTTP security
      2. Enter the value ** in the cURL blocked hosts list field and save
      3. Confirm you see a validation warning
      4. Now, check the 'Only http cookies' checkbox and save again
      5. Verify that:
        • The 'Only http cookies' value is saved (should be checked now) and 
        • You see a warning about the ** value in the blocked hosts field
      6. Reload the page and confirm the changes have stuck (i.e. check that 'Only http cookies' is still checked and that the blocked hosts is empty.
      Show
      As admin : Go to Admin > Security > HTTP security Enter the value ** in the cURL blocked hosts list field and save Confirm you see a validation warning Now, check the 'Only http cookies' checkbox and save again Verify that: The 'Only http cookies' value is saved (should be checked now) and  You see a warning about the ** value in the blocked hosts field Reload the page and confirm the changes have stuck (i.e. check that 'Only http cookies' is still checked and that the blocked hosts is empty.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60767-master-3

      Description

      See notes on MDLQA-11583 failure:
      Looks like some validation problems on step 14 + 15 (I did these both before saving the settings form). Basically, I don't see any error about python path, and it just 'silently' saves the new time splitting methods and reverts the predictions processor to php without any warning/info. I'll create an MDL to address this now.

      To replicate (all branches version):
      As admin:

      1. Go to Admin > Security > HTTP security
      2. Enter the value ** in the cURL blocked hosts list field and save
      3. Confirm you see a validation warning
      4. Now, check the 'Only http cookies' checkbox and save again
      5. Notice that you don't see a warning about the ** value this time and that the other value (checkbox) has saved.
      6. Now, change only the blocked hosts field and save
      7. Notice the warning that should have occurred earlier.

        Attachments

        1. Step3-Confirmed_Master.PNG
          81 kB
          Gladys Basiana
        2. Step5-Confirmed_Master.PNG
          83 kB
          Gladys Basiana
        3. Step6- Confirmed_Master.PNG
          85 kB
          Gladys Basiana

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Simey Lameze
              Integrator:
              Damyon Wiese
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18