[MDL-60789] Workshop/Submissions - Form doesn't check title field for maxlength 255 - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Pull from Repository:
git://github.com/sarjona/moodle.git
Pull Master Branch:
~~MDL-60789~~-master
Pull Master Diff URL:
https://github.com/sarjona/moodle/commit/3dbb8dc598879c242099102e66e054d54bf1834a
Testing Instructions:
Hide

Set up

Login as teacher

Create a workshop, configure it and move to the "Submission phase"

Testing instructions

Login as student

Access to the workshop

Try to create a submission with a title longer than 255 characters and save changes

CHECK no "Writing database error" appears

CHECK submission is not saved because an "Maximum of 255 characters" message appears below title

Modify the title with less than 255 characters and save changes

CHECK submission is sent correctly
Show
Set up Login as teacher Create a workshop, configure it and move to the "Submission phase" Testing instructions Login as student Access to the workshop Try to create a submission with a title longer than 255 characters and save changes CHECK no "Writing database error" appears CHECK submission is not saved because an "Maximum of 255 characters" message appears below title Modify the title with less than 255 characters and save changes CHECK submission is sent correctly

When creating a new submission, the user is able to enter titles more than 255 characters long.

When he does this, he gets only a simple "Database error occurred".

See [https://github.com/moodle/moodle/blob/master/mod/workshop/submission_form.php|submission form code].

Fix: Add a simple rule, like this:

$mform->addRule('title', null, 'maxlength', 255, 'client');

Participants:: CiBoT, Daniel Poggenpohl, David Monllaó, David Mudrák (@mudrd8mz), Sara Arjona (@sarjona)

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)