Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60790

enrol_plugin::can_edit_instance() does nothing

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.3.3, 3.4
    • Enrolments
    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • MDL-60790-master
    • Hide

      Testing scenario 1

      1. Access as admin
      2. Edit the "Teacher" role to allow the enrol/manual:config capability (it should be enabled, but it's better to check it)
      3. Access to a course as teacher
      4. Go to Enrolment methods page
        • CHECK the cog appears for the Manual enrolment method
      5. Click over the cog and copy the URL of the editing form for the Testing scenario 2.

      Testing scenario 2

      1. Access as admin
      2. Edit the "Teacher" role to remove enrol/manual:config capability
      3. Access to a course as teacher
      4. Go to again to Enrolment methods page
        • CHECK the cog doesn't appear for the Manual enrolment method, but appears for the others
      5. Access directly from your browser to the saved URL in the 5th step of the previous scenario
        • CHECK you can't edit the Manual enrolment and you're redirected to "Enrolment methods" page again
      Show
      Testing scenario 1 Access as admin Edit the "Teacher" role to allow the enrol/manual:config capability (it should be enabled, but it's better to check it) Access to a course as teacher Go to Enrolment methods page CHECK the cog appears for the Manual enrolment method Click over the cog and copy the URL of the editing form for the Testing scenario 2. Testing scenario 2 Access as admin Edit the "Teacher" role to remove enrol/manual:config capability Access to a course as teacher Go to again to Enrolment methods page CHECK the cog doesn't appear for the Manual enrolment method, but appears for the others Access directly from your browser to the saved URL in the 5th step of the previous scenario CHECK you can't edit the Manual enrolment and you're redirected to "Enrolment methods" page again

      The enrolment plugin base class has a can_edit_instance() method, but this is not called anywhere in the codebase. It seems to have been replaced by use_standard_editing_ui() without being deprecated properly.

        1. screenshot-1.png
          screenshot-1.png
          345 kB

            Unassigned Unassigned
            maherne Michael Aherne
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            Damyon Wiese Damyon Wiese
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 minute
                1m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.