Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60817

Notify the user when the original file extension has been removed or modified upon file editing in the filepicker

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test with both Boost and Classic themes.

      1. Login as Admin.
      2. Create a Course.
      3. Enroll a Student in the Course.
      4. Create an Assignment activity.
        1. For 'Submission types' enable 'File submissions'
      5. Login as a Student.
      6. Upload a file (e.g. .docx) and submit the assignment.
      7. Go back to the Assignment.
      8. Edit the assignment.
      9. Click the file in the 'File submissions' panel
      10. Remove the .docx file extension from the 'Name' input field
      11. Press 'Update'
        1. make sure a pop up dialog is displayed and notifies the Student that the file extension has been modified during the file update process and request a confirmation for the update action.
        2. Verify the confirmation dialogue appears in the center of the screen (borrowed from MDL-68168).
      Show
      Test with both Boost and Classic themes. Login as Admin. Create a Course. Enroll a Student in the Course. Create an Assignment activity. For 'Submission types' enable 'File submissions' Login as a Student. Upload a file (e.g. .docx) and submit the assignment. Go back to the Assignment. Edit the assignment. Click the file in the 'File submissions' panel Remove the .docx file extension from the 'Name' input field Press 'Update' make sure a pop up dialog is displayed and notifies the Student that the file extension has been modified during the file update process and request a confirmation for the update action. Verify the confirmation dialogue appears in the center of the screen (borrowed from MDL-68168 ).
    • Workaround:
      Hide

      An Admin/Teacher can define 'Accepted file types' (e.g. file types that are supported by the document converter) in the assignment's settings page under 'Submission types'. This would disable the Students to upload or modify a file extension to something that is not supported by the document converter

      Show
      An Admin/Teacher can define 'Accepted file types' (e.g. file types that are supported by the document converter) in the assignment's settings page under 'Submission types'. This would disable the Students to upload or modify a file extension to something that is not supported by the document converter
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-60817-master-4
    • Story Points:
      1
    • Sprint:
      Activity Sprint 4, Activity Sprint 5, Activity Sprint 6, Activity Sprint 7, Activity Sprint 8, Activity Sprint 9

      Description

      Quite commonly, users remove the document file extension when editing the filename in the filepicker, without being aware of that.

      In some specific cases, for ex. students editing the name of an existing assignment submission file, if the extension is removed or modified it can cause failure in the document conversion in the assignment.

      Improving the UX in the filepicker, by notifying the users when the original file extension has been modified would greatly reduce these occurrences.

        Attachments

        1. Boost_15.59.51.png
          165 kB
          Víctor Déniz Falcón
        2. Classic_16.00.31.png
          163 kB
          Víctor Déniz Falcón
        3. image1.png
          116 kB
          Mike Wilson
        4. image2.png
          81 kB
          Mike Wilson
        5. multiple_warning_messages_before.png
          23 kB
          Mihail Geshoski
        6. multiple_warning_messages.png
          30 kB
          Mihail Geshoski
        7. multiple_warning_messages.png
          30 kB
          Mihail Geshoski
        8. Test MDL-60817 Boost Passed - Screenshot 2020-03-19 at 07.49.18.png
          127 kB
          Carlos Escobedo
        9. Test MDL-60817 Classic Passed -Screenshot 2020-03-19 at 07.50.01.png
          127 kB
          Carlos Escobedo
        10. TestPassed - Boost.png
          171 kB
          Carlos Escobedo
        11. TestPassed Classic.png
          126 kB
          Carlos Escobedo

          Issue Links

            Activity

              People

              Assignee:
              Geshoski Mihail Geshoski
              Reporter:
              mikewilsonuk Mike Wilson
              Peer reviewer:
              Peter Dias
              Integrator:
              Víctor Déniz Falcón
              Tester:
              Carlos Escobedo
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              10 Vote for this issue
              Watchers:
              14 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 10 minutes
                  2d 10m