Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60842

calendar_get_allowed_types should not request all course fields

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 3.4, 3.4 regressions
    • 3.4.1
    • Calendar
    • MOODLE_34_STABLE
    • MOODLE_34_STABLE
    • MDL-60842-master
    • Hide
      1. Create 50,000 courses by downloading create_courses_and_stuff.php to your Moodle instance's root folder and running it:
        #

        php create_courses_and_stuff.php
        

      2. Log in as admin and go to the Calendar.
      3. Click New event button.
      4. Make sure it loads the event form and no "undefined" error message is displayed.
      Show
      Create 50,000 courses by downloading create_courses_and_stuff.php to your Moodle instance's root folder and running it: # php create_courses_and_stuff.php Log in as admin and go to the Calendar. Click New event button. Make sure it loads the event form and no "undefined" error message is displayed.

    Description

      The method calendar_get_allowed_types() calls calendar_get_default_courses() passing * as parameter. That loads all course fields and causes an "undefined" error when loading the new event form modal

      We (Ryan and I) have decided to push small chunks of performance improvements (we also have MDL-60402 and MDL-60826), so we can get rid of that nasty undefined error.

      Attachments

        1. create_courses_and_stuff.php
          3 kB
          Simey Lameze
        2. undefined error.png
          105 kB
          Simey Lameze

        Issue Links

          Activity

            People

              lameze Simey Lameze
              lameze Simey Lameze
              Ankit Agarwal Ankit Agarwal
              David Monllaó David Monllaó
              Gladys Basiana Gladys Basiana
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                15/Jan/18