Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60861

Do not allow models to be enabled if no time splitting method is selected

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4.1
    • Component/s: Analytics
    • Labels:
    • Testing Instructions:
      Hide
      1. Revert the second commit of this patch.
      2. Go to admin/tool/analytics/index.php
      3. You should have a model "Students at risk of dropping out" with no timesplitting method defined.
      4. Try enabling that model, make sure you get an error.
      5. Apply the second commit.
      6. Make sure there is no option to enable the model now.
      Show
      Revert the second commit of this patch. Go to admin/tool/analytics/index.php You should have a model "Students at risk of dropping out" with no timesplitting method defined. Try enabling that model, make sure you get an error. Apply the second commit. Make sure there is no option to enable the model now.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60861-master
    • Pull Master Diff URL:

      Description

      To select a time splitting method is required in order to use a model. If a model does not have a time splitting method if can not work. We should remove the 'Enable' option from the actions menu until a time splitting method is selected.

        Attachments

        1. Selection_545.png
          Selection_545.png
          57 kB
        2. Selection_546.png
          Selection_546.png
          62 kB
        3. Selection_547.png
          Selection_547.png
          56 kB
        4. Selection_548.png
          Selection_548.png
          45 kB

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-60532 Mark time splitting methods as mandatory field while editing model

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              dmonllao David Monllaó
              Peer reviewer:
              Simey Lameze
              Integrator:
              Damyon Wiese
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18