Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60874

Misleading search results in new user enrolment control

    XMLWordPrintable

Details

    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-60874-master-enrolautocomplete
    • Hide

      Note: Manual testing is not needed, the fix is covered by Behat tests.

      If you still want to test this manually: The user selector has been changed so that:

      • It now displays up to 100 users.
      • If there are more than 100 users matching the search criteria, we do not display their list. Instead, a notice "Too many users (>100) to show" is shown and the user has to provide more specific criteria. This behaviour is consistent with the legacy user selector.
      Show
      Note: Manual testing is not needed, the fix is covered by Behat tests. If you still want to test this manually: The user selector has been changed so that: It now displays up to 100 users. If there are more than 100 users matching the search criteria, we do not display their list. Instead, a notice "Too many users (>100) to show" is shown and the user has to provide more specific criteria. This behaviour is consistent with the legacy user selector.

    Description

      In the new "enrol users" control, the search results can be very misleading.

      Firstly, it's not particularly clear that there's a 30 record limit.

      Secondly (and probably more importantly), the 30 record limit doesn't take account of users already selected.

      To reproduce the problem:

      1. Create forty users: Person One (user1@example.com) etc
      2. Go into participants in a course and click "enrol users"
      3. Search for example.com
      4. You see the first 30 users. Select them all.
      5. Search again for example.com - you see a message saying "no suggestions" so you think you have enrolled everyone from example.com, but there are still 10 users who are never shown for that search (even if you search for something else and go back to it)

      I realise this may seem like a very contrived example, but it's common in universities for departments to run a course for a group of people in a partner organisation. In that case they'll generally search by the organisation's email domain rather than for each person individually.

      Attachments

        Issue Links

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              maherne Michael Aherne
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Votes:
              14 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Sep/18