Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60918

Altering other users messaging preferences updates yours instead

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.4, 3.5
    • Fix Version/s: 3.3.5, 3.4.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as an admin
      2. View your messaging preferences (Preferences > User account > Message preferences)
      3. In another tab, view the preferences for another user (copy paste the URL and set the "id" parameter to another user's userid)
      4. On the tab with the other user's preferences displayed, change one or more preferences.
      5. Refresh the page.
        • Confirm your changes have persisted.
      6. Go back to the tab with the preferences of the user you've logged in as and refresh it,
        • Confirm that your preferences have not changed.
      Show
      Login as an admin View your messaging preferences (Preferences > User account > Message preferences) In another tab, view the preferences for another user (copy paste the URL and set the " id " parameter to another user's userid) On the tab with the other user's preferences displayed, change one or more preferences. Refresh the page. Confirm your changes have persisted. Go back to the tab with the preferences of the user you've logged in as and refresh it, Confirm that your preferences have not changed.
    • Workaround:
      Hide

      Use moodle's login-as functionality to switch to the target user to alter their messaging preferences.

      Show
      Use moodle's login-as functionality to switch to the target user to alter their messaging preferences.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60918-master

      Description

      As an admin or someone else with access, if you browse to another users message preferences (message/edit.php?id=X) - attempting to use any of the on/off toggle buttons does not alter that users preferences as you expect - it in fact is updating yours, even though you're looking at the page for another user.

      This appears to be caused by the userid not being sent along with the api request.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ryanwyllie Ryan Wyllie
              Reporter:
              aolley Adam Olley
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Helen Foster
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                19/Mar/18