Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60924

Filters lost after clicking "Show all {$num}" link on Participants page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4, 3.4.4, 3.5.1
    • Fix Version/s: 3.4.5, 3.5.2
    • Component/s: User management
    • Labels:
    • Testing Instructions:
      Hide

      It should be covered by Behat. However, here there are also some manual tests.

      Setup

      1. Prepare a course with 30 students and 1 teacher

      Testing scenario 1 (Show all button)

      1. Access as teacher to the participants page of this course
      2. Filter users by "Role: student"
        • CHECK that the "Number of participants" is 30
      3. At the end of the page, click on the "Show all 30" link
        • CHECK that the "Role: student" is still present
        • CHECK that the "Number of participants" is 30
      4. At the end of the page, click on the "Show 20 per page" link
        • CHECK that the "Role: student" is still present
        • CHECK that the "Number of participants" is 30
      5. At the end of the page, click on the "Show all 30" link
      6. Remove the filter
        • CHECK that there is no active filter
        • CHECK that the "Number of participants" is 31
        • CHECK that all the participants are displayed on the same page

      Testing scenario 2 (Letters filter)

      1. Access as teacher to the participants page of this course
      2. Filter users by "Role: student"
      3. Click on one of the letters link on the First name row
        • CHECK that the "Role: student" is still present
        • CHECK that the "Number of participants" is the total of users with the First name starting with the selected letter
      4. Remove the "Role: student" filter
        • CHECK that there is no active filter
        • CHECK that the "Number of participants" is still the total of users with the First name starting with the selected letter
      Show
      It should be covered by Behat. However, here there are also some manual tests. Setup Prepare a course with 30 students and 1 teacher Testing scenario 1 (Show all button) Access as teacher to the participants page of this course Filter users by "Role: student" CHECK that the "Number of participants" is 30 At the end of the page, click on the "Show all 30" link CHECK that the "Role: student" is still present CHECK that the "Number of participants" is 30 At the end of the page, click on the "Show 20 per page" link CHECK that the "Role: student" is still present CHECK that the "Number of participants" is 30 At the end of the page, click on the "Show all 30" link Remove the filter CHECK that there is no active filter CHECK that the "Number of participants" is 31 CHECK that all the participants are displayed on the same page Testing scenario 2 (Letters filter) Access as teacher to the participants page of this course Filter users by "Role: student" Click on one of the letters link on the First name row CHECK that the "Role: student" is still present CHECK that the "Number of participants" is the total of users with the First name starting with the selected letter Remove the "Role: student" filter CHECK that there is no active filter CHECK that the "Number of participants" is still the total of users with the First name starting with the selected letter
    • Workaround:
      Hide

      After clicking "Show all {$num}", if you re-apply the filter, you will see in a single page the users that meet the filter.

      It is a bit annoying to have to do it twice, but at the moment it lets get all the users that fulfill a filter on a page.

      Show
      After clicking "Show all {$num}", if you re-apply the filter, you will see in a single page the users that meet the filter. It is a bit annoying to have to do it twice, but at the moment it lets get all the users that fulfill a filter on a page.
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-60924-master

      Description

      I have 894 users in a course, when I select a group (São Luis - Turma A) the filter works well, but when I click on "Show all {$num}" link the filter is reseted and the page prints all the 894 users. If there is more than one filter all will be deleted.

      To reproduce:

      • Go to the Participants page
      • Add a filter(i.e group, role...)
      • The page filter the results(OK)
      • At the end of the page I click on "Show all {$num}" link
      • The filter is reseted and all the users are printed on the page

      ${num} means the number of returned users after applied the filter.

      PS: I hide the users table to show the link and the sum of users affected by the filter

        Attachments

        1. Screen Shot 2018-07-18 at 11.38.16 am.png
          99 kB
          Mark Nelson
        2. text821-2-1.png
          247 kB
          Willian Mano Araujo

          Issue Links

            Activity

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18