Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60945

core_completion_get_activities_completion_status web service internally gets more progress records than required

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      The unit tests should cover this, specifically:

      vendor/bin/phpunit core_completion_externallib_testcase completion/tests/externallib_test.php

      Show
      The unit tests should cover this, specifically: vendor/bin/phpunit core_completion_externallib_testcase completion/tests/externallib_test.php
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When core_completion_external::get_activities_completion_status() is called it retrieves progress for all users on a course, before discarding all but one record.

      The query that does this can have its efficiency improved by using completion_info::get_progress_all in a way that only gets the progress for the user that the method is interested in.

        Attachments

          Activity

            People

            Assignee:
            nmagill Neill Magill
            Reporter:
            nmagill Neill Magill
            Peer reviewer:
            Jake Dallimore
            Integrator:
            Damyon Wiese
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17