Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60959

Remove redundancy in calendar exporters for calendar month view

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.5
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Test

      1. Log in as admin
      2. Install the Deutsch language pack
        • Site administration > language > language packs
      3. Enable the multilang filter for content and headings
        • Site administration > plugins > filters > manage filters
      4. Create a course and set a multilang filtered content as the course short name, for example <span lang="en" class="multilang">C1</span><span lang="de" class="multilang">D1</span>
      5. View the course and click the “Calendar” link in the nav drawer (this takes you to the “course” calendar)
      6. Create a new event for the course you just created (it should be pre-filled with the course details)
      7. CONFIRM that the event is created successfully
      8. Click on the event in the calendar
      9. CONFIRM that the event summary modal shows with the correct course name
      10. CONFIRM that the course name is a link to the course (and that it’s the correct course)
      11. Hover over the day with the course event in the “MONTHLY VIEW” block on the right of the calendar
      12. CONFIRM that the course short name is shown in the popup and the multilang filter is being applied (only the current language should be visible)
      13. Change the page language to Deutsch (in the nav bar)
      14. Hover over the day in the “MONTHLY VIEW” clock again
      15. CONFIRM that the course short name is still there but this time you see the Deutsch version
      16. Change language pack to English (or carry on in Deutsch if you feel like it)
      17. Click the day number in the calendar month on a day that has at least one event (the little number should be a link)
      18. CONFIRM that you are taken to the day view for the day you clicked
      19. CONFIRM that you see the event in the day view
      Show
      Test Log in as admin Install the Deutsch language pack Site administration > language > language packs Enable the multilang filter for content and headings Site administration > plugins > filters > manage filters Create a course and set a multilang filtered content as the course short name, for example <span lang="en" class="multilang">C1</span><span lang="de" class="multilang">D1</span> View the course and click the “Calendar” link in the nav drawer (this takes you to the “course” calendar) Create a new event for the course you just created (it should be pre-filled with the course details) CONFIRM that the event is created successfully Click on the event in the calendar CONFIRM that the event summary modal shows with the correct course name CONFIRM that the course name is a link to the course (and that it’s the correct course) Hover over the day with the course event in the “MONTHLY VIEW” block on the right of the calendar CONFIRM that the course short name is shown in the popup and the multilang filter is being applied (only the current language should be visible) Change the page language to Deutsch (in the nav bar) Hover over the day in the “MONTHLY VIEW” clock again CONFIRM that the course short name is still there but this time you see the Deutsch version Change language pack to English (or carry on in Deutsch if you feel like it) Click the day number in the calendar month on a day that has at least one event (the little number should be a link) CONFIRM that you are taken to the day view for the day you clicked CONFIRM that you see the event in the day view
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull Master Branch:
      MDL-60959-master

      Description

      The exporters for the calendar month view are doing a few redundant calculations that can be removed.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18