Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60968

Auth plugins data mapping fields cannot accept urls

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin.
      2. Go to Site administration > Plugins > Authentication
      3. Enable External Database plugin by clicking the eye icon.
      4. Once enabled, click Settings link.
      5. Fill the for with your local DB information (host, database.. and etc) and go to Data mapping section, and add the following url as First name data mapping (http://schemas.xmlsoap.org/ws/2005/05/identity/claims/upn"
      6. Click Save changes button.
      7. Make sure you don't get an error message:

        Some settings were not changed due to an error.
        

      8. You should see Changes saved confirmation.
      Show
      Log in as admin. Go to Site administration > Plugins > Authentication Enable External Database plugin by clicking the eye icon. Once enabled, click Settings link. Fill the for with your local DB information (host, database.. and etc) and go to Data mapping section, and add the following url as First name data mapping ( http://schemas.xmlsoap.org/ws/2005/05/identity/claims/upn " Click Save changes button. Make sure you don't get an error message: Some settings were not changed due to an error. You should see Changes saved confirmation.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60968-master

      Description

      As maintainer of the auth_saml2 plugin I'm getting regular bug reports that people cannot map the data fields which are being provided by ADFS into user accounts. This mapping stuff is managed by core, and saml in some situations provides the attributes for a user using a namespaced url. Here are a recent bug raised:

      https://github.com/catalyst/moodle-auth_saml2/issues/124#issuecomment-321437159

      Here is another with a couple workarounds:

      https://github.com/catalyst/moodle-auth_saml2/issues/166#issue-278972808

      But I can't see any real reason why this is limited in core, so I'd like to relax the validation for these fields.

       

        Attachments

          Activity

            People

            Assignee:
            brendanheywood Brendan Heywood
            Reporter:
            brendanheywood Brendan Heywood
            Peer reviewer:
            Simey Lameze
            Integrator:
            Damyon Wiese
            Tester:
            Sara Arjona (@sarjona)
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jan/18