[MDL-60969] Hardcoded strings in LDAP config settings - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Pull from Repository:
git://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-60969~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-60969_master
Testing Instructions:
Hide

Install the PHP LDAP extension (required so that the settings appear).

sudo apt install php-ldap

sudo service apache2 restart

Visit 'Site administration' > 'Authentication' > 'Manage authentication'.

Click on the settings for 'LDAP server'.

Confirm for the setting 'auth_ldap | expiration' the 'No' is capitalised.

Confirm the other option is 'LDAP server'.

Confirm the description for the setting makes sense.
Show
Install the PHP LDAP extension (required so that the settings appear). sudo apt install php-ldap sudo service apache2 restart Visit 'Site administration' > 'Authentication' > 'Manage authentication'. Click on the settings for 'LDAP server'. Confirm for the setting 'auth_ldap | expiration' the 'No' is capitalised. Confirm the other option is 'LDAP server'. Confirm the description for the setting makes sense.

The LDAP settings contain the hardcoded strings 'no' and 'LDAP server'.

Discovered while testing

MDL-40613 Auth LDAP does not sync custom fields from LDAP to local moodle DB

is a regression caused by

MDL-12689 convert all auth plugins to use settings.php

Participants:: CiBoT, Damyon Wiese, Gladys Basiana, Jun Pataleta, Mark Nelson, Mihail Geshoski

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo