Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60985

User Tour: last step: the 'end tour' button should be blue, not 'next' button.

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.9
    • 3.3.1, 3.3.2, 3.8
    • User Tours
    • MOODLE_33_STABLE, MOODLE_38_STABLE
    • MOODLE_39_STABLE
    • MDL-60985-master
    • Hide
      1. Go to a page which has a user tour, e.g. the dashboard.
      2. If the user tour does not start automatically, click on "Reset user tour on this page".
      3. In the first step of the tour verify there is no "Previous" button.
      4. Enjoy the whole tour (click next on every step).
      5. In the last step of the tour verify there is no "Next" button and the "End tour" button has the plain blue primary button style.

      Show
      Go to a page which has a user tour, e.g. the dashboard. If the user tour does not start automatically, click on "Reset user tour on this page". In the first step of the tour verify there is no "Previous" button. Enjoy the whole tour (click next on every step). In the last step of the tour verify there is no "Next" button and the "End tour" button has the plain blue primary button style.

      On the last step of a user tour, the 'Next' button has a class of 'btn-primary', making it blue (but disabled).

      It would be less confusing to users if this was removed on the last step, and that class added to the 'end tour' button instead.

      -----------------------------------------------------

      Suggested change to tour.js (feel free to improve if it's not great coding):

      Line 711 original: template.find('[data-role="next"]').prop('disabled', true)

      Line 711 change: template.find('[data-role="next"]').prop('disabled', true).removeClass("btn-primary");

       

      Add:    

      if (this.isLastStep(stepConfig.stepNumber)) {
              template.find('[data-role="end"]').addClass("btn-primary");
          } else {
              template.find('[data-role="end"]');
      }

            lucaboesch Luca Bösch
            leelumultipass1 Rebecca Trynes
            Tobias Garske Tobias Garske
            Jake Dallimore Jake Dallimore
            Amaia Anabitarte Amaia Anabitarte
            Votes:
            3 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.