Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.3.1, 3.3.2, 3.8
-
Fix Version/s: 3.9
-
Component/s: User Tours
-
Testing Instructions:
- Go to a page which has a user tour, e.g. the dashboard.
- If the user tour does not start automatically, click on "Reset user tour on this page".
- In the first step of the tour verify there is no "Previous" button.
- Enjoy the whole tour (click next on every step).
- In the last step of the tour verify there is no "Next" button and the "End tour" button has the plain blue primary button style.
Go to a page which has a user tour, e.g. the dashboard. If the user tour does not start automatically, click on "Reset user tour on this page". In the first step of the tour verify there is no "Previous" button. Enjoy the whole tour (click next on every step). In the last step of the tour verify there is no "Next" button and the "End tour" button has the plain blue primary button style. -
Affected Branches:MOODLE_33_STABLE, MOODLE_38_STABLE
-
Fixed Branches:MOODLE_39_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-60985-master -
Pull Master Diff URL:
Description
On the last step of a user tour, the 'Next' button has a class of 'btn-primary', making it blue (but disabled).
It would be less confusing to users if this was removed on the last step, and that class added to the 'end tour' button instead.
-----------------------------------------------------
Suggested change to tour.js (feel free to improve if it's not great coding):
Line 711 original: template.find('[data-role="next"]').prop('disabled', true)
Line 711 change: template.find('[data-role="next"]').prop('disabled', true).removeClass("btn-primary");
Add:
if (this.isLastStep(stepConfig.stepNumber)) {
template.find('[data-role="end"]').addClass("btn-primary");
} else {
template.find('[data-role="end"]');
}
Attachments
Issue Links
- will help resolve
-
MDL-57157 User tours shows Next on the last item
-
- Closed
-
