Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60985

User Tour: last step: the 'end tour' button should be blue, not 'next' button.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.1, 3.3.2, 3.8
    • Fix Version/s: 3.9
    • Component/s: User Tours
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to a page which has a user tour, e.g. the dashboard.
      2. If the user tour does not start automatically, click on "Reset user tour on this page".
      3. In the first step of the tour verify there is no "Previous" button.
      4. Enjoy the whole tour (click next on every step).
      5. In the last step of the tour verify there is no "Next" button and the "End tour" button has the plain blue primary button style.

      Show
      Go to a page which has a user tour, e.g. the dashboard. If the user tour does not start automatically, click on "Reset user tour on this page". In the first step of the tour verify there is no "Previous" button. Enjoy the whole tour (click next on every step). In the last step of the tour verify there is no "Next" button and the "End tour" button has the plain blue primary button style.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-60985-master

      Description

      On the last step of a user tour, the 'Next' button has a class of 'btn-primary', making it blue (but disabled).

      It would be less confusing to users if this was removed on the last step, and that class added to the 'end tour' button instead.

      -----------------------------------------------------

      Suggested change to tour.js (feel free to improve if it's not great coding):

      Line 711 original: template.find('[data-role="next"]').prop('disabled', true)

      Line 711 change: template.find('[data-role="next"]').prop('disabled', true).removeClass("btn-primary");

       

      Add:    

      if (this.isLastStep(stepConfig.stepNumber)) {
              template.find('[data-role="end"]').addClass("btn-primary");
          } else {
              template.find('[data-role="end"]');
      }

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              leelumultipass1 Rebecca Trynes
              Peer reviewer:
              Tobias Garske
              Integrator:
              Jake Dallimore
              Tester:
              Amaia Anabitarte
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m