Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.3.3, 3.4, 3.5
-
Testing Instructions:
-
Affected Branches:MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
Fixed Branches:MOODLE_33_STABLE, MOODLE_34_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-60997-master -
Pull Master Diff URL:
Description
As explained in comment-399078 on MDL-51382
message_ouput_email::send_message() correctly use "replytoname" (if specified) message/output/email/message_output_email.php#L88 and pass it to email_to_user (message/output/email/message_output_email.php#L94).
But "replytoname" is not a valid property of core\message (lib/classes/message/message.php#L117) so even if we wanted to we could not use it.
In my (misplaced) commit b5aaa1 on MDL-51382 i set it and use it in forum_cron() to see the original post author when replying by mail.
As suggested by Ben Chenoweth in his comment-490402 on MDL-51382 i think we should include it into master.
I'll provide a patch without forum_cron() changes.
Should i add them or should it be discussed in an other issue ?
Attachments
Issue Links
- has been marked as being related by
-
MDL-51382 lost the name of sender in From: when forum_replytouser unset
-
- Reopened
-