[MDL-61002] Backport MDL-48766 MDL-56331 and MDL-56740 to 31. - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.9
Fix Version/s: 3.1.10
Component/s: Unit tests
Labels:

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Testing Instructions:
Hide

Run PHPUnit with the PHPUNIT_LONGTEST constant defined

Note: CI does define PHPUNIT_LONGTEST on some of the tests so this can be handed to CI for testing.
Show
Run PHPUnit with the PHPUNIT_LONGTEST constant defined Note: CI does define PHPUNIT_LONGTEST on some of the tests so this can be handed to CI for testing.

Description

We applied ~~MDL-56331~~ and ~~MDL-56740~~ to 32 and up, but neglected to apply it to 31.
Although 31 is under security support only, we also want to have passing unit tests wherever possible, and these are causing unit test failures when combined with the PHPUNIT_LONGTEST constant.

Attachments

Issue Links

has a non-specific relationship to

MDL-56331 core_iplookup_geoip_testcase is failing

Closed

MDL-56740 iplookup/tests/geoip_test.php is failing

Closed

MDL-48766 Support IPv6 in IP lookup tool

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Damyon Wiese

Integrator:: Damyon Wiese

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Eloy Lafuente (stronk7)

Component watchers:

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 11/Dec/17 4:01 PM

Updated:: 15/Dec/17 8:45 AM

Resolved:: 15/Dec/17 8:45 AM

Fix Release Date:: 15/Jan/18