Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61050

Regression: NTLM Redirect Failure

    XMLWordPrintable

    Details

      Description

      There is a missing > on line 1687 of auth/ldap/auth.php, introduced in https://tracker.moodle.org/browse/MDL-42834 I did a quick check of the other changes in this commit but just this one line is missing the character

      • redirect($CFG->httpswwwroot.'/login/index.php?authldap_skipntlmsso=1');

      + redirect($CFG-wwwroot.'/login/index.php?authldap_skipntlmsso=1');

       

      I've added that > to my local files and it works correctly again

       

      The result is that when NTLM login fails (due to unsupported browser within NTLM subnet) it attempts to redirect to the manual login page (/login/index.php?authldap_skipntlmsso=1) but now fails as the redirect link is generated incorrectly with extra characters (/login/1/login/index.php?authldap_skipntlmsso=1)

       Rob

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              danmarsden Dan Marsden
              Reporter:
              ride365 ride365
              Peer reviewer:
              Mark Nelson
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Nobody
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18