Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61052

Assign onlinetext submission with HTML media causes document converter to queue endlessly

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing steps:

      1. As Admin create a Course and enrol a student.
      2. Install the attached document converter plugin (extract the contents to files/converter).
      3. Enable the Media Test converter and ensure it is the only document converter enabled.
      4. As Admin or Teacher, create an Assignment with:
        • Submission types = Online text
      5. As Admin or Teacher, go to the Assignment -> View all submissions page.
      6. Select a student, and access the Edit menu -> Edit submission.
      7. Add some HTML content for the Assignment's Online text and add some images.
      8. Click the "Media" button (the icon looks like a camera on a document)
        1. Click the "Video" tab
        2. Paste in the following URL: https://www.youtube.com/watch?v=rNFoOHI9iJw
        3. Press "Insert media"
      9. Click the "Media" button again
        1. Stay on the "Link" tab
        2. Paste in the following URL: https://www.youtube.com/watch?v=rNFoOHI9iJw
        3. Add "My Video" as the name of the link.
        4. Press "Insert media"
      10. On the Assignment submission, access the 'Show more buttons' button -> 'HTML' button.
      11. You should then see the HTML code for the current Online text submission.
      12. Find the img tag(s) and edit the alt="..." text values.
      13. Press "Save changes".
      14. As Admin or Teacher, go to back to the Assignment -> View all submissions page but do not click "Grade" on the student yet.
      15. tail -f your apache error log
      16. Press "Grade" for the student's submission to trigger the document conversion.
      17. The Apache error log should not see any DOMDocument errors. It should only show successful debugging messages from the Media Test converter similar to:

        [Thu Jun 28 20:38:04.481168 2018] [php7:notice] [pid 31947] [client 172.20.254.136:38560] Starting conversion, id: 5b34d6ac75780, referer: http://zig.per.in.moodle.com/m/stable_master/mod/assign/view.php?id=124&rownum=0&action=grader&userid=3
        [Thu Jun 28 20:38:05.582691 2018] [php7:notice] [pid 27048] [client 172.20.254.136:20152] Polling conversion with id: 5b34d6ac75780, referer: http://zig.per.in.moodle.com/m/stable_master/mod/assign/view.php?id=124&rownum=0&action=grader&userid=3
        [Thu Jun 28 20:38:05.598321 2018] [php7:notice] [pid 27048] [client 172.20.254.136:20152] Conversion with id: 5b34d6ac75780 marked as complete, referer: http://zig.per.in.moodle.com/m/stable_master/mod/assign/view.php?id=124&rownum=0&action=grader&userid=3

      18. As Admin, disable the Media Test converter and enable the Unoconv converter.
      19. Repeat testing from Step 5, and ensure the Online text is modified to trigger the conversion again in Step 15.
      20. The converted document should show the img alt messages.
      21. The Apache error log should not see any DOMDocument errors.
         
      Show
      Testing steps: As Admin create a Course and enrol a student. Install the attached document converter plugin (extract the contents to files/converter). Enable the Media Test  converter and ensure it is the only document converter enabled. As Admin or Teacher, create an Assignment with: Submission types = Online text As Admin or Teacher, go to the Assignment -> View all submissions page. Select a student, and access the Edit menu -> Edit submission. Add some HTML content for the Assignment's Online text and add some images. Click the "Media" button (the icon looks like a camera on a document) Click the "Video" tab Paste in the following URL:  https://www.youtube.com/watch?v=rNFoOHI9iJw Press "Insert media" Click the "Media" button again Stay on the "Link" tab Paste in the following URL:  https://www.youtube.com/watch?v=rNFoOHI9iJw Add "My Video" as the name of the link. Press "Insert media" On the Assignment submission, access the 'Show more buttons' button -> 'HTML' button. You should then see the HTML code for the current Online text submission. Find the img tag(s) and edit the alt="..." text values. Press "Save changes". As Admin or Teacher, go to back to the Assignment -> View all submissions page but  do not  click "Grade" on the student yet. tail -f  your apache error log Press "Grade" for the student's submission to trigger the document conversion. The Apache error log should not see any DOMDocument errors. It should only show successful debugging messages from the Media Test  converter similar to: [Thu Jun 28 20:38:04.481168 2018] [php7:notice] [pid 31947] [client 172.20.254.136:38560] Starting conversion, id: 5b34d6ac75780, referer: http://zig.per.in.moodle.com/m/stable_master/mod/assign/view.php?id=124&rownum=0&action=grader&userid=3 [Thu Jun 28 20:38:05.582691 2018] [php7:notice] [pid 27048] [client 172.20.254.136:20152] Polling conversion with id: 5b34d6ac75780, referer: http://zig.per.in.moodle.com/m/stable_master/mod/assign/view.php?id=124&rownum=0&action=grader&userid=3 [Thu Jun 28 20:38:05.598321 2018] [php7:notice] [pid 27048] [client 172.20.254.136:20152] Conversion with id: 5b34d6ac75780 marked as complete, referer: http://zig.per.in.moodle.com/m/stable_master/mod/assign/view.php?id=124&rownum=0&action=grader&userid=3 As Admin, disable the Media Test converter and enable the Unoconv converter. Repeat testing from Step 5, and ensure the Online text is modified to trigger the conversion again in Step 15. The converted document should show the img alt messages. The Apache error log should not see any DOMDocument errors.  
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-61052-master

      Description

      Prerequisites

      1. A site with a course
      2. Some students enrolled in the course
      3. An assignment in the course with online text submissions enabled

      Reproduction steps:

      1. Install the attached document converter plugin (extract the contents to files/converter)
      2. Enable the "Media Test" converter and ensure it is the only document converter enabled
      3. As a student go to the assignment and click the "Media" button (the icon looks like a camera):
        1. Click the "video" tab
        2. Paste in the following URL: https://www.youtube.com/watch?v=rNFoOHI9iJw
        3. Press "Insert media"
        4. Press "Save changes"
      4. As an admin or teacher in the course browse to the list of submissions for the assignment (but don't click grade on any of them yet)
      5. tail -f your apache error log
      6. Press "grade" for the student's submission
      7. Watch your error log and you will conversions keep getting created but never resolved because the poll method is never called

      This seems to have something to do with the VideoJS filter, it adds a unique ID when it converts the text, which I guess makes the conversion logic think it's a brand new submission every time.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18