Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61062

Random failure in analytics/tests/model_test.php test_unique_id

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4, 3.5
    • Fix Version/s: 3.4.1
    • Component/s: Analytics
    • Labels:

      Description

      The following failure has been reported by integration ci server

      1) analytics_model_testcase::test_unique_id
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'04ee5ed03ff233bb89fe0719b44700e4d405843a'
      +'5e4698a48f250bf0adc56a46a5d75e23e850ac1e'
       
      /var/lib/jenkins/git_repositories/master/analytics/tests/model_test.php:230
      /var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit analytics_model_testcase analytics/tests/model_test.php
      

      I've skimmed through the test code and it seems that $this->model->enable('\core\analytics\time_splitting\deciles'); should trigger a version update so the next line should really be a NotEquals (the solution may require a sleep(1) again...

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jan/18