Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.5
-
Fix Version/s: 3.5
-
Component/s: Global search
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_35_STABLE
-
Fixed Branches:MOODLE_35_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-61076-master -
Pull Master Diff URL:
Description
The search areas screen contains the following action buttons:
- Update indexed contents
- Reindex all site contents
- Delete all indexed contents
- Delete index (against each search area)
These options are relatively benign on test sites, but for sites with a substantial search index, all these buttons are potentially risky or damaging:
- Update indexed contents - if pressed when index has not yet been created, might take an unreasonably long time and likely time out in the web browser.
- Reindex all site contents - will take an unreasonably long time and time out in the web browser.
- Delete all indexed contents - will immediately break search for all users until such time as the index can be rebuilt.
- Delete index - will immediately break search within that search area for all users until such time as the index can be rebuilt.
For example, on my employer's main system, if somebody hits 'delete all indexed contents' it will take approximately a month before search works properly again. This would probably not be considered acceptable by students.
All these options are available only to administrators but administrators can press buttons by accident too! I propose adding a confirmation screen for each option.
Additionally there is one other problem with this screen even when used for testing - after taking some of these actions, it remains in the URL. If, like I did, you delete a search area and then some time later reload the page (intending just to see how far indexing has got in that search area) you may find yourself deleting the search area again! A confirmation screen (which then redirects back to the normal view after carrying out the action) would also solve this problem.