Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61103

Make all xmldb numerical types to support same max integer value

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5
    • Fix Version/s: None
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE

      Description

      This is a followup of the validation changes performed @ MDL-32113.

      Right now, no matter it's not used often... we allow integers (or whole parts in decimals/floats) up to 20 digits.

      It's allowed by database engines, but php runs out of max int value (64 bits PHP_INT_MAX 9223372036854775807 which is 19 digits).

      So this is about to discuss id we should be reducing from 20 down to 19 (or 18 in fact) the max number of digits allowed for all xmldb numerical types (integer, number, float).

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: