Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61194

Assign fails to convert files when both online text and file submissions are enabled under some circumstances

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Install and enable the attached fileconverter plugin (it would be prudent to do this on a fresh install):
        1. Extract the contents of the zip to files/convert
        2. Browse to "Site administration > Plugins > Document converters > Manage document converters" and open the eye on the "Dummy" converter - ensure all other converters are disabled
      2. Create an assignment with file submissions and onlinetext enabled
        • (Master only) Also ensure that "Annotate PDF" feedback type is enabled
      3. As a student submit a png or jpg file for the assignment (don't submit anything in the onlinetext box - or I guess you can. It doesn't matter so much. Up to you)
      4. Log back in as admin and grade the assignment submitted previously
      5. Verify you see a handsome lad after the conversion is finished
      Show
      Install and enable the attached fileconverter plugin (it would be prudent to do this on a fresh install): Extract the contents of the zip to files/convert Browse to "Site administration > Plugins > Document converters > Manage document converters" and open the eye on the "Dummy" converter - ensure all other converters are disabled Create an assignment with file submissions and onlinetext enabled (Master only) Also ensure that "Annotate PDF" feedback type is enabled As a student submit a png or jpg file for the assignment (don't submit anything in the onlinetext box - or I guess you can. It doesn't matter so much. Up to you) Log back in as admin and grade the assignment submitted previously Verify you see a handsome lad after the conversion is finished
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61194-master

      Description

      If an assignment accepts both online text and file submissions, it's possible to be in a situation where the files never get converted. This happens when none of the available converters support html.

      The document services code will queue multiple files for conversion, there is always an HTML file for the online text submission and the others are file submissions. The HTML one always seems to be first in the list, and when the get_status function in combined_document.php is checking the combination status, as soon as it finds one of the files to be unconvertable, it fails the whole thing. So what happens is it fails on the HTML file when there are no converters available for it - even though we may still be able to convert the other files.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h