Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61211

Error occurring when answers or responses contain break tag in lesson questions

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as Admin.
      2. Enable Developer mode.
        • Go to Site administration > Development > Debugging.
        • Set "Debug messages" = "DEVELOPER: extra Moodle debug messages for developers".
        • Save changes.
      3. Create a Course.
      4. Enrol Students to the Course.
      5. Create Lesson activity into the Course.
      6. Add questions to the Lesson:
        • Add Essay question.
        • Add Matching question.
          • Add 'Correct response'.
            • Check the source code of the response in the textarea editor and make sure that "<br>" tag is present.
          • Add 'Wrong response'
            • Check the source code of the response in the textarea editor and make sure that "<br>" tag is present.
          • Add several Matching pairs.
        • Add Multichoice question.
          • Disable 'Multiple-answer'. 
          • Add several Answers with responses.
            • Check the source code of the answers and responses in the textarea editor and make sure that "<br>" tag is present.
        • Create a duplicate of the Multichoice question and edit the duplicate.
          • Enable 'Multiple-answer'.
        • Add Numerical question.
          • Add several Answers with responses.
            • Check the source code of the responses in the textarea editor and make sure that "<br>" tag is present.
        • Add Short answer question.
          • Add several Answers with responses.
            • Check the source code of the responses in the textarea editor and make sure that "<br>" tag is present.
        • Add True/false question.
          • Add answers and responses for 'Correct response' and 'Wrong response'
            • Check the source code of the answers and responses in the textarea editor and make sure that "<br>" tag is present.
      7. Log in as a Student enrolled into the Course.
      8. Attempt the Lesson.
      9. Answer the questions.
        • make sure an error is NOT displayed.
        • make sure the answers and responses are correctly displayed.  
      Show
      Log in as Admin. Enable Developer mode. Go to Site administration > Development > Debugging. Set "Debug messages" = "DEVELOPER: extra Moodle debug messages for developers". Save changes. Create a Course. Enrol Students to the Course. Create Lesson activity into the Course. Add questions to the Lesson: Add Essay question. Add Matching question. Add 'Correct response'. Check the source code of the response in the textarea editor and make sure that "<br>" tag is present. Add 'Wrong response' Check the source code of the response in the textarea editor and make sure that "<br>" tag is present. Add several Matching pairs. Add Multichoice question. Disable 'Multiple-answer'.  Add several Answers with responses. Check the source code of the answers and responses in the textarea editor and make sure that "<br>" tag is present. Create a duplicate of the Multichoice question and edit the duplicate. Enable 'Multiple-answer'. Add Numerical question. Add several Answers with responses. Check the source code of the responses in the textarea editor and make sure that "<br>" tag is present. Add Short answer question. Add several Answers with responses. Check the source code of the responses in the textarea editor and make sure that "<br>" tag is present. Add True/false question. Add answers and responses for 'Correct response' and 'Wrong response' Check the source code of the answers and responses in the textarea editor and make sure that "<br>" tag is present. Log in as a Student enrolled into the Course. Attempt the Lesson. Answer the questions. make sure an error is NOT displayed. make sure the answers and responses are correctly displayed.   
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-61211-master

      Description

      Starting with the new (as of this post) 3.4.1 build retrieved by issuing a git pull, matching questions generate an error when displaying feedback. It is possible it is related to the fix @ MDL-43042

      Steps:

      • Create a lesson
      • Add a matching page type
      • Complete the questions and click Submit.
      • A PHP error is generated and no feedback is provided. The other question types appear to work correctly.

      See the attached images from our development site (3.4.1) and the QA site (https://qa.moodle.net/mod/lesson/view.php?id=28&pageid=33  3.5?) for the errors generated.

       

        Attachments

        1. lesson1.PNG
          lesson1.PNG
          153 kB
        2. lesson2.PNG
          lesson2.PNG
          66 kB
        3. lesson3.PNG
          lesson3.PNG
          109 kB
        4. lesson4.PNG
          lesson4.PNG
          34 kB
        5. 1.PNG
          1.PNG
          216 kB
        6. 1a.PNG
          1a.PNG
          231 kB

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  19/Mar/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 30 minutes
                  1h 30m