Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61233

Quick enrol popup is broken for some themes in IE

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites

      A course and some users that are to be enrolled in the course

      NB: Test on IE 10 or above and use the "clean" theme.

      1. Browse to the course participants page
      2. Wait a second to make sure JS loads
      3. Click the "Enrol users" button in the top right
      4. Select one of your users from the drop down in the popup
      5. Press the "Enrol users" button on the popup
      6. Verify that the popup closes and the user is now present in the list of enrolled users
      7. It would also be nice to test in some other browsers and with some other themes (boost, for example)
      Show
      Prerequisites A course and some users that are to be enrolled in the course NB: Test on IE 10 or above and use the "clean" theme. Browse to the course participants page Wait a second to make sure JS loads Click the "Enrol users" button in the top right Select one of your users from the drop down in the popup Press the "Enrol users" button on the popup Verify that the popup closes and the user is now present in the list of enrolled users It would also be nice to test in some other browsers and with some other themes (boost, for example)
    • Affected Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61233-master

      Description

      In IE 10+, using the clean theme (or any other theme based on bootstrapbase), try using the quick enrol popup to enrol a user in a course. When you press the "enrol users" button, nothing will happen.

      The issue is this code:

      enrol/manual/amd/src/quickenrolment.js

      139
      hidden.each(function() {
      140
          this.remove();
      141
      });
      

      ChildNode.remove() is not supported in IE: https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove so it doesn't work. The fix is simple since we have jQuery, though:

      $(this).remove();
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                cameron1729 cameron1729
                Reporter:
                cameron1729 cameron1729
                Peer reviewer:
                Sara Arjona (@sarjona)
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: