Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61234

User tours race condition

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Mostly covered by unit tests.
      You may wish to test during integration:

      1. Open admin/tool/usertours/amd/src/usertours.js in your preferred editor.
      2. Find the fetchTour function
      3. At the top of the function add: 

        var test = $.Deferred();

      4. On the templates.render line, change it to: 

        templates.render('tool_usertours/tourstep', {}), test

      5. After the .fail(notification.exception); line, add: 

        setTimeout(test.resolve, 10000);

      6. run grunt uglify
      7. run behat against the Aria tags should not exist test
        1. Confirm it passed

      For extra browny points, repeat the test reverting this change.

      Show
      Mostly covered by unit tests. You may wish to test during integration: Open admin/tool/usertours/amd/src/usertours.js in your preferred editor. Find the fetchTour function At the top of the function add: var test = $.Deferred(); On the templates.render line, change it to: templates.render('tool_usertours/tourstep', {}), test After the .fail(notification.exception); line, add: setTimeout(test.resolve, 10000); run grunt uglify run behat against the Aria tags should not exist test Confirm it passed For extra browny points, repeat the test reverting this change.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61234-master
    • Pull Master Diff URL:

      Description

      admin/tool/usertours/tests/behat/tour_filter.feature:162

      001 Scenario: Aria tags should not exist # /var/www/html/moodle/admin/tool/usertours/tests/behat/tour_filter.feature:62
      		 
            When I click on "Next" "button"    # /var/www/html/moodle/admin/tool/usertours/tests/behat/tour_filter.feature:68
      		 
              Button matching locator "'Next'" not found.

      This appears to happen because we look for next whilst still fetching the initial content.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60079 User tours leave unnecessary aria tags in the page

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Ryan Wyllie Ryan Wyllie
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                19/Mar/18