Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.4.1, 3.5
-
MOODLE_34_STABLE, MOODLE_35_STABLE
-
MOODLE_34_STABLE
-
Description
When preparing Moodle for 7.2 (MDL-60279), we weren't able to test the sqlsrv driver yet (because it was not available).
Some minutes ago I've been finally able to get sqlsrv working under php 7.2 as part of:
https://github.com/moodlehq/moodle-php-apache/issues/16
and immediately have start getting thousands of warnings:
PHP Warning: count(): Parameter must be an array or an object that implements Countable
|
in /var/www/html/lib/dml/sqlsrv_native_moodle_database.php on line 446
|
We already faced similar cases, easy to fix, specially here because we can use null that is the default value instead of count(). In fact all other drivers are using null comparison since the beginning of the times.
And that's all... proceeding... ciao