Loading...

XML

Word

Printable

Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
git://github.com/Kathrin84/moodle.git
Pull Main Branch:
~~MDL-61298~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...Kathrin84:MDL-61298-master
Testing Instructions:
Hide

Login with a user that is enrolled into at least one course with sections

Go to this course

Open the nav drawer (if not already opened)

See that all menu items in the nav drawer have a suitable icon in front of the item title
Show
Login with a user that is enrolled into at least one course with sections Go to this course Open the nav drawer (if not already opened) See that all menu items in the nav drawer have a suitable icon in front of the item title

Currently, only special nodes have icons in the Boost navigation (nav drawer).
Moreover those icons are hard coded within the template:
https://github.com/moodle/moodle/blob/d509f80c48f4ef49a03ab8396eec869bc7563882/theme/boost/templates/flat_navigation.mustache#L70

We don't know why these icons are hard coded, especially because navigation nodes can deliver their own icons:
https://github.com/moodle/moodle/blob/d509f80c48f4ef49a03ab8396eec869bc7563882/lib/navigationlib.php#L104

So we think this could be improved in the way that the template renders the delivered icon.

Best, Kathrin

caused a regression

MDL-62987 Incorrect spelling of 'empty'

is blocked by

MDL-61343 Theme Boost: Simplify and harmonise flat_navigation.mustache

will be (partly) resolved by

MDL-62365 Remove dropdown items default empty circle icon (Boost)

MDL-62367 Assign icons to module navigation

Participants:: Alexander Bias, Andrew Lyons, Anna Carissa Sadia, Barbara Ramiro, Bas Brands, CiBoT, David Monllaó, Jake Dallimore, Kathrin Osswald, Luca Bösch, Marina Glancy

Estimated:

Remaining:

Logged:

30m