Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61298

Boost: Use the navigation node's icon in the flat_navigation template

    XMLWordPrintable

Details

    • MOODLE_35_STABLE
    • MOODLE_35_STABLE
    • MDL-61298-master
    • Hide
      1. Login with a user that is enrolled into at least one course with sections
      2. Go to this course
      3. Open the nav drawer (if not already opened)
      4. See that all menu items in the nav drawer have a suitable icon in front of the item title
      Show
      Login with a user that is enrolled into at least one course with sections Go to this course Open the nav drawer (if not already opened) See that all menu items in the nav drawer have a suitable icon in front of the item title

    Description

      Currently, only special nodes have icons in the Boost navigation (nav drawer).
      Moreover those icons are hard coded within the template:
      https://github.com/moodle/moodle/blob/d509f80c48f4ef49a03ab8396eec869bc7563882/theme/boost/templates/flat_navigation.mustache#L70

      We don't know why these icons are hard coded, especially because navigation nodes can deliver their own icons:
      https://github.com/moodle/moodle/blob/d509f80c48f4ef49a03ab8396eec869bc7563882/lib/navigationlib.php#L104

      So we think this could be improved in the way that the template renders the delivered icon.

      Best, Kathrin

      Attachments

        1. 61298-proposed.png
          61298-proposed.png
          89 kB
        2. coursemanagement.png
          coursemanagement.png
          111 kB
        3. current.png
          current.png
          234 kB
        4. homeicon.png
          homeicon.png
          106 kB
        5. proposal.png
          proposal.png
          242 kB
        6. Screen Shot 2018-03-19 at 09.32.31.png
          Screen Shot 2018-03-19 at 09.32.31.png
          169 kB
        7. Step4_MDL-61298.PNG
          Step4_MDL-61298.PNG
          39 kB

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62987 Incorrect spelling of 'empty'

          • Major - Major loss of function, incorrect output
          • Closed
          is blocked by

          Improvement - An enhancement to an existing Moodle feature. MDL-61343 Theme Boost: Simplify and harmonise flat_navigation.mustache

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62365 Remove dropdown items default empty circle icon (Boost)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-62367 Assign icons to module navigation

          • Minor - Minor loss of function where workaround is possible
          • Open

          Activity

            People

              kosswa Kathrin Osswald
              kosswa Kathrin Osswald
              Bas Brands Bas Brands
              David Monllaó David Monllaó
              Anna Carissa Sadia Anna Carissa Sadia
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/18

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m