-
Bug
-
Resolution: Fixed
-
Minor
-
3.1.10, 3.2.7, 3.3.4, 3.4.1, 3.4.4, 3.5.1
-
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
MOODLE_34_STABLE, MOODLE_35_STABLE
-
- Download the patch (0001-TEST-Not-to-be-integrated.patch
) attached to this issue - Apply it:
git am 0001-TEST-Not-to-be-integrated.patch - Purge caches
- Ensure that debugdisplay is enabled and developer debug levels are set
- Open a course
- Turn editing on
- Note: You will see a deprecation notice (all good)
- Confirm that there are no warnings about "Undefined property stdClass::$name"
- Click "Add an activity or resource"
- Confirm that you see two "Chat" activities:
- Chat - With a valid help string
- Chat - Without a valid help string
- Confirm that you see two "Chat" activities:
- Select "Chat - With a valid help string"
- Confirm that the help string is shown on the right
- Select "Chat - Without a valid help string
- Confirm that the string "There is currently no help associated with this resource activity" is shown instead
Download the patch ( 0001-TEST-Not-to-be-integrated.patch ) attached to this issue Apply it: git am 0001-TEST-Not-to-be-integrated.patch Purge caches Ensure that debugdisplay is enabled and developer debug levels are set Open a course Turn editing on Note: You will see a deprecation notice (all good) Confirm that there are no warnings about " Undefined property stdClass::$name " Click "Add an activity or resource" Confirm that you see two "Chat" activities : Chat - With a valid help string Chat - Without a valid help string Select "Chat - With a valid help string" Confirm that the help string is shown on the right Select "Chat - Without a valid help string Confirm that the string "There is currently no help associated with this resource activity" is shown instead - Download the patch (0001-TEST-Not-to-be-integrated.patch
lots of entries in our error log like this:
PHP Notice: Undefined property: stdClass::$name in moodle/course/lib.php on line 1340,
looks like $name is never actually populated at this point - seems to be an issue in all branches.
creation of $subtype->name is moved from here:
https://github.com/moodle/moodle/commit/9ca0420e931fe877f33af54297f973c3beccaee3#diff-4c9e15f220b139143bd8750342ca43e5L1292
further down the function, but it is moved too far down the function.
- is a regression caused by
-
MDL-45064 Option to add Preconfigured LTI Tool to Activity Chooser
-
- Closed
-
