-
Bug
-
Resolution: Fixed
-
Minor
-
3.3.4, 3.4.1, 3.5
-
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
MOODLE_33_STABLE, MOODLE_34_STABLE
-
MDL-61341-master -
When testing our binary sass compiler on 3.4.1 we discovered a couple of issues with scss.
issue 1: z-index concatination
The usertour overlay uses z-index of $flexitour-base-zindex + 2, this was producing 1040 + 2 = 10402 instead of the expected 1042.
issue 2: math on incompatible units: rem and em
doing on math on 1rem + 2em is not supported, the PHP compiler was ignoring the second unit and doing everything in the unit of the first value.
I had originally made a function to strip units, but Andrew found a suitable variable so all math is done in rem. ($input-padding-y-sm instead of $tag-padding-y)
Andrew also suggested raising this as a bug in the upstream PHP sass compiler.